Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories List: Add typography support #43254

Merged
merged 1 commit into from Aug 16, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds typography support to the Categories block.

Why?

  • Allows some typography control over the categories list
  • Increases consistency in terms of available design tools across blocks

How?

  • Opts into all typography supports
  • Only exposes the font size control by default as this is the most common config.

Testing Instructions

  1. Load the block editor, add a categories list block and select it
  2. Within the sidebar experiment with various typography settings (note the list's inner links will have their own underline style. Can address in a follow-up)
  3. Your selected styles should appear both in the editor and the frontend after saving
  4. Switch to the site editor, ensure a categories list block is on the page/template in question.
  5. Navigate to Global Styles > Blocks > Categories List > Typography and confirm these styles get applied

Screenshots or screencast

Screen.Recording.2022-08-16.at.6.47.11.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Categories Affects the Categories Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
@apeatling apeatling self-requested a review August 16, 2022 17:31
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Within the sidebar experiment with various typography settings (note the list's inner links will have their own underline style. Can address in a follow-up)
✅ Your selected styles should appear both in the editor and the frontend after saving
✅ Navigate to Global Styles > Blocks > Categories List > Typography and confirm these styles get applied

Screenshot 2022-08-16 at 10 31 20 AM

@aaronrobertshaw aaronrobertshaw merged commit b5dcc59 into trunk Aug 16, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/categories-typography-support branch August 16, 2022 22:59
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 16, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants