Navigation block: Create classic menus empty #43190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
|
Size Change: +159 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
scruffian
commented
Aug 12, 2022
| @@ -247,6 +247,7 @@ function Navigation( { | |||
| status: classicMenuConversionStatus, | |||
| error: classicMenuConversionError, | |||
| value: classicMenuConversionResult, | |||
| classicInnerBlocks: classicMenuConversionInnerBlocks, | |||
There was a problem hiding this comment.
This is used to pass the innerBlocks to the block from the hook.
There was a problem hiding this comment.
scruffian
commented
Aug 12, 2022
| @@ -359,6 +360,8 @@ function Navigation( { | |||
| showClassicMenuConversionNotice( | |||
| __( 'Classic menu imported successfully.' ) | |||
| ); | |||
|
|
|||
| replaceInnerBlocks( clientId, classicMenuConversionInnerBlocks ); | |||
There was a problem hiding this comment.
This does work, but other changes get triggered which means they get wiped.
scruffian
commented
Aug 12, 2022
| @@ -65,13 +66,11 @@ function useConvertClassicToBlockMenu( clientId ) { | |||
|
|
|||
| // 2. Convert the classic items into blocks. | |||
| const { innerBlocks } = menuItemsToBlocks( classicMenuItems ); | |||
| setClassicInnerBlocks( innerBlocks ); | |||
There was a problem hiding this comment.
So that they can be passed from the hook back to the component,
scruffian
commented
Aug 12, 2022
| menuName, | ||
| innerBlocks | ||
| ); | ||
| navigationMenu = await createNavigationMenu( menuName, [] ); |
There was a problem hiding this comment.
We don't need this change.
scruffian
commented
Aug 12, 2022
| @@ -100,7 +99,7 @@ function useConvertClassicToBlockMenu( clientId ) { | |||
| setValue( null ); | |||
| setError( null ); | |||
|
|
|||
| convertClassicMenuToBlockMenu( menuId, menuName ) | |||
| return convertClassicMenuToBlockMenu( menuId, menuName ) | |||
There was a problem hiding this comment.
We don't need this change.
scruffian
changed the title
draganescu
force-pushed
the
try/page-list-fallback
branch
2 times, most recently
from
efcdb1e
to
6072b40
Compare
|
We did this in a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an attempt to fix #42850
Why?
When you create a new navigation menu from a classic menu then a new wp_navigation CPT is created, which is already populated with the content of the classic navigation. The upshot of this is that as soon as the classic navigation is created the fallback behaviour of the block is changed and the classic menu is used instead of page list (as described in #42799)
How?
When we create a new "classic" wp_navigation CPT we do it without any innerblocks, so its empty. This means that the fallback behaviour is unchanged. We then populate the inner blocks with the navigation items that were returned from the API. This should mark the block as "dirty" for the entity saving flow, so it feels like it should be a simpler approach.
Testing Instructions
To replicate the issue
With this PR enabled
6. The fallback is unchanged
7. (not working from this point) You should see the classic menu inner blocks in the editor
8. When you go to save you have the option to save the new CPT
9. When you have saved the frontend now displays the classic navigation menu items.