Border Controls/Color Palette: Ensure popovers remain within small viewports #41930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
force-pushed
the
fix/border-control-popovers-on-small-viewports
branch
from
a055d70
to
9d7964e
Compare
aaronrobertshaw
force-pushed
the
fix/border-control-popovers-on-small-viewports
branch
from
9d7964e
to
b1136e6
Compare
aaronrobertshaw
changed the title
|
Size Change: +7 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Thanks for fixing this up @aaronrobertshaw! This is getting the ColorPicker to show within the smaller viewports now, while not affecting the positioning on desktop viewport sizes:
| Color picker is now visible in global styles | Custom color picker can be viewed in inspector controls | Color pickers are now visible for BoxControl and split controls |
|---|---|---|
 |
 |
 |
As you mention in the PR description, some of the repositioning of the popovers is a bit clunky, but I agree, it'd be good to get this visibility fix in as a priority, and we can investigate the ideal positioning within the viewport in follow-ups 👍
aaronrobertshaw
changed the title
aaronrobertshaw
deleted the
fix/border-control-popovers-on-small-viewports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Ensures that BorderControl and BorderBoxControl popovers are positioned within smaller viewports.
Note: The automatic repositioning of popovers since the floatingUI changes is a little clunky. This PR only aims to restore the popovers to the viewport so they are usable until we refine the popover behaviour more generally.
Why?
After the switch to using floatingUI library for Popovers, they aren't repositioned by default when they fall outside the viewport. Without this the popovers are unusable.
How?
Turns on
__unstableShiftfor the border control popovers as well as the custom color picker popover.Testing Instructions
Screenshots or screencast
Screen.Recording.2022-06-29.at.11.48.34.am.mp4
Screen.Recording.2022-06-29.at.11.45.19.am.mp4