New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#30930 - Make it easier to select "Edit visually" when in "Edit as HTML #41516
Merged
adamziel
merged 7 commits into
WordPress:trunk
from
adambasa-dp:edit-visually-edit-html
Jun 21, 2022
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
25b32d0
#30930 - Make it easier to select "Edit visually" when in "Edit as H…
adambasa-dp b2584af
BlockVisuallyConvertButton name converted to BlockEditVisuallyButton
adambasa-dp 81338e5
title removed from the <ToolbarButton/> component
adambasa-dp b450d4c
code formatting fix
adambasa-dp 906b694
Reversed buttons order
adambasa-dp 7d0b5b6
divider between the button and the ellipsis
adambasa-dp 2b2540c
Update packages/block-editor/src/components/block-settings-menu/block…
adamziel File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
52 changes: 52 additions & 0 deletions
52
packages/block-editor/src/components/block-settings-menu/block-edit-visually-button.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { rawHandler, getBlockContent } from '@wordpress/blocks'; | ||
import { ToolbarButton, ToolbarGroup } from '@wordpress/components'; | ||
import { __ } from '@wordpress/i18n'; | ||
import { useSelect, useDispatch } from '@wordpress/data'; | ||
import { useCallback } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { store as blockEditorStore } from '../../store'; | ||
|
||
export default function BlockEditVisuallyButton( { clientIds, ...props } ) { | ||
const { block, shouldRender } = useSelect( | ||
( select ) => { | ||
const firstBlockClientId = clientIds[ 0 ]; | ||
const { isBlockMultiSelected, getBlockMode, getBlock } = | ||
select( blockEditorStore ); | ||
const isSingleSelected = | ||
! isBlockMultiSelected( firstBlockClientId ); | ||
const isHtmlMode = getBlockMode( firstBlockClientId ) === 'html'; | ||
|
||
return { | ||
block: getBlock( firstBlockClientId ), | ||
shouldRender: isSingleSelected && isHtmlMode, | ||
}; | ||
}, | ||
[ clientIds[ 0 ] ] | ||
); | ||
|
||
const { replaceBlocks } = useDispatch( blockEditorStore ); | ||
const onClick = useCallback( () => { | ||
replaceBlocks( | ||
block.clientId, | ||
rawHandler( { HTML: getBlockContent( block ) } ) | ||
); | ||
}, [ block ] ); | ||
|
||
if ( ! shouldRender ) { | ||
return null; | ||
} | ||
|
||
return ( | ||
<ToolbarGroup> | ||
<ToolbarButton onClick={ onClick } { ...props }> | ||
{ __( 'Edit visually' ) } | ||
</ToolbarButton> | ||
</ToolbarGroup> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to actually trying out this PR. It works fine, but I now see that the button appears after the ellipsis. Shouldn't it be placed before it?
Besides that, this PR is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZebulanStanphill I did it according to the design from that issue #30930
IMHO it's ok, but we can change the order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also suggest putting the button before the ellipsis (with a divider between) to avoid breaking a widespread UI convention.