Webfonts: Fix webfont loading in the Site Editor

[scruffian]

What?

This ensures that all Webfonts from all variations are loaded in the Site Editor

Why?

We need to load all Webfonts for every variation so that when a user previews the variation they see their fonts.

How?

The merging of Webfonts assumed that they fontFamilies were stored under settings > typography > fontFamilies but they are actually under settings > typography > fontFamilies > theme`.

Testing Instructions

• Check out this PR: Twenty Twenty-Two: add alternate style variations wordpress-develop#2440
• Switch to TT2
• Load the Site Editor
• Switch between the different style variations:

• Confirm that you see the different font files load in the network tab

[jffng]

Tests well for me:

It looks like the preview tiles of the style variations still do not load the fonts, but that's probably a separate issue.

[kjellr]

+1, this fixes the issue for me! As noted by @jffng, the previews do not get the correct font though.

[kjellr]

This may be unrelated, but I'm not seeing the secondary font weights loaded in (on both the front end or the back end). This is not a problem for Inter or Source Serif (since those are variable fonts), but it's an issue for DM Sans:

^ In this example, the post title should be bold, but that 700 weight is never loaded in.

[jffng]

@gziolo since this fixes a bug with style variations, can this be marked for backporting to Core?

[scruffian]

I am AFK the next few days so if someone wants to finish this off please be my guest...

[gziolo]

@gziolo since this fixes a bug with style variations, can this be marked for backporting to Core?

The changes are applied to the PHP file which is in the experiemental folder. It doesn’t look like Webfonts API made it to WP 6.0. @priethor and @annezazu, can you confirm that?

[jasmussen]

It would be problematic for TwentyTwentyTwo and style variants without this.

[jasmussen]

@gziolo there's a section on webfonts in the dev notes tracking issue: #39654 and from what I can tell, #37140 should be in 6, right?

[gziolo]

@gziolo there's a section on webfonts in the dev notes tracking issue: #39654 and from what I can tell, #37140 should be in 6, right?

See #39889 and the note from @hellofromtonya:

Webfonts are still in development. PR #39559 moves the files into the lib/experimentation folder until the API is ready for WordPress Core commit.

The code is stil in the lib/experimental folder and we didn't get any confirmation that it's ready to backport to WordPress core.

[bph]

Sorry @jasmussen the section was added without knowing that WebfontsAPI hasn't merged into the Beta 1.

[jffng]

Thanks everyone for the comments. Since this fixes the issue described and the tests are passing, any objections to merging this?

It sounds like there is still the decision to be made whether Webfonts makes it in to 6.0, which means TT2s style variations would lack custom fonts. We could enqueue fonts for the style variations the old way, but I don't think that's a good idea or precedent to set.

[kjellr]

It sounds like there is still the decision to be made whether Webfonts makes it in to 6.0, which means TT2s style variations would lack custom fonts. We could enqueue fonts for the style variations the old way, but I don't think that's a good idea or precedent to set.

Yeah, I agree there. Part of the allure of styles is the ability to swap out a variety of styles: fonts, colors, image treatments, settings etc. We can technically build in more font support manually, but it would be an unfortunate way to do things since this is so close otherwise.

The feature is still listed as a must-have for RC: #40139