Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor/ to .markdownlintignore #39724

Merged
merged 3 commits into from Mar 25, 2022
Merged

Add vendor/ to .markdownlintignore #39724

merged 3 commits into from Mar 25, 2022

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented Mar 24, 2022

What?

Add vendor/ to .markdownlintignore
for wp-scripts, to match the documented behavior
https://developer.wordpress.org/block-editor/reference-guides/packages/packages-scripts/#lint-md-docs

Why?

Documentation states:

By default, files located in build, node_modules, and vendor folders are ignored.

How?

Testing Instructions

  1. Open a project that has some lint errors in /vendor folder, like https://github.com/woocommerce/google-listings-and-ads/
  2. Run wp-scripts lint-md-docs

Before

> wp-scripts lint-md-docs

…
vendor/automattic/jetpack-a8c-mc-stats/README.md:35 MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```php"]
vendor/automattic/jetpack-assets/README.md:7 MD001/heading-increment/header-increment Heading levels should only increment by one level at a time [Expected: h2; Actual: h3]

Screenshots or screencast

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Good catch 👍

Any idea why CI checks didn’t trigger?

Would you mind including an entry in the CHANGELOG file similar to:

https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#bug-fix

@tomalec
Copy link
Contributor Author

tomalec commented Mar 25, 2022

Any idea why CI checks didn’t trigger?

😕 maybe because I created this PR via GitHub UI?

Would you mind including an entry in the CHANGELOG file similar to:

Done 80ea265

@gziolo gziolo merged commit 2943570 into WordPress:trunk Mar 25, 2022
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 25, 2022
@gziolo
Copy link
Member

gziolo commented Mar 25, 2022

Thank you for the changelog change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Scripts /packages/scripts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants