Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripts: Add new flag to allow customization of the src directory. #39618

Merged
merged 18 commits into from Apr 5, 2022
Merged

Scripts: Add new flag to allow customization of the src directory. #39618

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c8a9c01
Add new flag to allow customization of the src directory.
ryanwelcher Mar 21, 2022
f334906
Add new flag to the build command.
ryanwelcher Mar 21, 2022
6465545
Update changelog.
ryanwelcher Mar 21, 2022
6438856
Add npmDevDependencies as a template variable. Update messaging to sh…
ryanwelcher Mar 24, 2022
6f24eb8
Merge remote-tracking branch 'upstream/trunk' into trunk
ryanwelcher Mar 25, 2022
37ec581
Let's try dynamic entry points
gziolo Mar 28, 2022
c5a2b68
Update packages/scripts/CHANGELOG.md
gziolo Mar 28, 2022
4e2af84
Merge branch 'trunk' into try/scripts-custom-src-directory
gziolo Mar 28, 2022
19b81b0
Ensure that `block.json` is always loaded fresh in watch mode
gziolo Mar 28, 2022
c980cd2
Update CHANGELOG.md
gziolo Mar 28, 2022
0f50fcf
Update packages/scripts/utils/config.js
ryanwelcher Apr 4, 2022
0b691cc
Merge remote-tracking branch 'upstream/trunk' into trunk
ryanwelcher Apr 4, 2022
1ed44fc
Merge branch 'trunk' into try/scripts-custom-src-directory
ryanwelcher Apr 4, 2022
727ba85
Merge branch 'try/scripts-custom-src-directory' of github.com:ryanwel…
ryanwelcher Apr 4, 2022
188f23f
Remove duplicated code from merge.
ryanwelcher Apr 4, 2022
6d6b943
Fix typo for WebPack.
ryanwelcher Apr 4, 2022
c7075da
Formatting updates.
ryanwelcher Apr 4, 2022
04b0606
Updates to README.
ryanwelcher Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/create-block/lib/init-package-json.js
View file
Open in desktop
Expand Up @@ -121,5 +121,25 @@ module.exports = async ( {
}
}
}
info( '' );
info(
'Installing npm devDependencies. It might take a couple of minutes...'
);
for ( const packageArg of npmDevDependencies ) {
try {
checkDependency( packageArg );
info( '' );
info( `Installing "${ packageArg }".` );
await command( `npm install ${ packageArg } --save-dev`, {
cwd,
} );
} catch ( { message } ) {
info( '' );
info(
`Skipping "${ packageArg }" npm dev dependency. Reason:`
);
error( message );
}
}
}
};
2 changes: 1 addition & 1 deletion packages/scripts/config/webpack.config.js
View file
Open in desktop
Expand Up @@ -232,7 +232,7 @@ const config = {
new CopyWebpackPlugin( {
patterns: [
{
from: copyWebPackPattens,
from: copyWebPackPatterns,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIt: it's webpack not WebPack 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Nice catch - I've updated the reference.

context: process.env.WP_SRC_DIRECTORY,
noErrorOnMissing: true,
},
Expand Down