Scripts: Add .jsx file extension to Webpack #39613
Conversation
EliezerSPP
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @EliezerSPP! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
gziolo
added
[Package] Scripts
|
I’m surprised it was missing. Thank you for opening PR 👍 I guess it’s because we don’t use this extension in the Gutenberg project but other projects should be free to follow whatever the prefer. Would you mind including a short entry in the CHANGELOG file similar to: https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#bug-fix |
|
Congratulations on your first merged pull request, @EliezerSPP! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Added with f3b4f44. |
What?
Add .jsx file extension to Webpack Config
Why?
Import .jsx files without the extension