Site Editor: Add more template types #39353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Site Editor
18 tasks
|
Size Change: +2.02 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
mtias
added
the
[Feature] Themes
|
Nice, looks like a good first step. I'd still try to adjust the order so that we emphasize most common ones more (attachment, taxonomy, 404 towards the end). |
|
I updated the order to this: |
|
Looks good. There's something about the icons being centered on the left that looks somewhat off. I wonder if they'd look better top-aligned, with a baseline towards the template title? We also need a better 404 icon. Perhaps something like this? |
|
I added a commit to split the templates into static and dynamic. |
|
I don't think that split makes a ton of sense. 404 would be dynamic to the user from the perspective it can be shown for different permalinks. The only split I'd make is for "custom" templates (page templates or post type templates) that you can apply to existing posts or pages. |
scruffian
force-pushed
the
add/templates-to-site-editor
branch
from
7225052
to
349e890
Compare
|
OK I removed the divide for now, we can iterate that on another PR. I also updated the 404 icon... |
|
Nice. I wonder if the "Block Meta" icon might work better for the taxonomy template?
I noticed you renamed 'Attachment' to 'Media'. I think it's probably a good change, but might it trip up theme authors who are used to attachment.php? The Tag template description is missing a word. Not something to address here, but as we provide users with the ability to create more templates, the resulting blank canvas becomes a bigger issue. I don't know that this should be blocked by #37258, but it would be nice to get that in as well. |
This is the name that is already being used in Gutenberg - I just referenced that |
Looks good, do you have the SVG? |
|
I added some core tickets for the copy changes: |
|
Thank you for working on this Ben! It is much appreciated! Testing the PR using a local dev site running 5.9.2. I see this: The template list can gradually become fairly long. Should there be a way to sort (sorting icon in the top right corner on the line with Add New template) or default the list by alphabetical order? I like the overview of icons and the text. As it gives a visual hint as well as text that explains what each is. Adding the Author template. Author template in place. Should templates have default content added? Helping the process of adding content. |
|
How do you create a working attachment template that shows the attachment (The media)? |
|
Agreed, we should exclude Media / Attachment for now. |
|
Done in 9ec45b6 |
mtias
reviewed
Mar 14, 2022
| page, | ||
| archive, | ||
| search, | ||
| fourZeroFour, |
mtias
approved these changes
Mar 14, 2022
|
@scruffian sorry I thought it'd already been added to the library. Here's the svg: |
|
I added the block meta icon... |
scruffian
force-pushed
the
add/templates-to-site-editor
branch
from
046b859
to
fe5c793
Compare
gziolo
added
Backport to WP Beta/RC
gziolo
reviewed
Mar 15, 2022
| @@ -154,7 +154,7 @@ function get_default_block_template_types() { | |||
| ), | |||
| 'tag' => array( | |||
| 'title' => _x( 'Tag', 'Template name', 'gutenberg' ), | |||
| 'description' => __( 'Displays latest posts with single post tag.', 'gutenberg' ), | |||
| 'description' => __( 'Displays latest posts with a single post tag.', 'gutenberg' ), | |||
There was a problem hiding this comment.
@Mamaduka, it's a simple change that we could backport as a bug fix for WordPress 5.9.x since it was introduced in WP 5.9. Otherwise, we might miss it for WP 6.0 because it's in the compat folder for 5.9.
There was a problem hiding this comment.
I did also submit this as a core patch so maybe that's not necessary?
There was a problem hiding this comment.
I see https://core.trac.wordpress.org/ticket/55374 has landed but it won't be released until WP 6.0. Thank you!
gziolo
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds more template types to the Site Editor template creation flow, specifically:
Why?
So that users can create a broader selection of templates. Addresses, in part, #37407.
How?
Adding more template types is trivial - we just add them to the array. This PR also adds icons to the menu for each of these to make it easier to scan as per #37407. There are more changes suggested in #37407, including altering the order of these items and dividing them into logical groups. This PR is the first step towards that goal.
I'm not 100% sure about all of these icons - I couldn't find a paperclip icon...
Testing Instructions
Screenshots or screencast