-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'clickMenuItem' test util to use full label matching #39274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] E2E Test Utils
/packages/e2e-test-utils
[Type] Bug
An existing feature does not function as intended
[Type] Breaking Change
For PRs that introduce a change that will break existing functionality
and removed
[Type] Bug
An existing feature does not function as intended
labels
Mar 8, 2022
Size Change: -211 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
update/click-menu-item
branch
from
March 8, 2022 11:42
f95b3d4
to
00c497e
Compare
9 tasks
ntsekouras
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks George! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] E2E Test Utils
/packages/e2e-test-utils
[Type] Breaking Change
For PRs that introduce a change that will break existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR update
clickMenuItem
to use complete label matching. It should prevent clicking incorrect menu items when a label is partially matched.I've also updated the selector (per @ciampo's suggestion) to avoid relying on DOM structure and classes.
The previous discussion can be found here - #39183 (comment).
Testing Instructions
All e2e tests should pass.
Types of changes
Bugfix/Breaking change