ESLint Plugin: Make Prettier integration optional #39244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/eslint-plugin-prettier-optional
branch
from
9cb8132
to
27ef29d
Compare
gziolo
added
[Package] ESLint plugin
gziolo
force-pushed
the
update/eslint-plugin-prettier-optional
branch
from
27ef29d
to
a30ceed
Compare
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
|
I cherry-picked this PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39208.
This PR removes the alias of Prettier as a direct dependency of the
@wordpress/eslint-pluginpackage that should address this issue. To get us thereprettierbecomes an optional peer dependency. This enforces the consumer of the plugin to explicitly installprettierin their project to activate all custom rules related to code formatting. In that aspect, it might create some friction. However, in the case projects are using@wordpress/scriptseverything should work as before.Testing Instructions
Ensured that the following scripts work as before in Gutenberg:
npm run lint-jsnpm run format-jsTypes of changes
Breaking change (fix or feature that would cause existing functionality to not work as expected).
Checklist:
*.native.jsfiles for terms that need renaming or removal).