Site Editor: Remove dead code #37581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Size Change: -146 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Is this related to #37571 ? |
|
@mkaz, this is a general clean-up of the Re #37571 - we can probably ignore most of the "Can't perform a React state update on an unmounted component" warnings. React 18 is removing them - reactwg/react-18#82. |
|
Should we also get rid of these consts? I found them while looking for occurrences of the filenames of the files that this PR deletes. They look unused to me (but I don't know a lot more context): We might also wanna audit adjacent constants. |
ockham
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Seems to be working well, and I couldn't find any of theses files used anywhere in the codebase.
I'd suggest removing a few constants as part of this PR though: #37581 (comment)
|
|
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Site Editor: Remove dead code * Remove unused constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #36597.
Removes unused code left-overs after recent Template list refactoring.
I mostly checked for unimported components; this shouldn't affect anything.
How has this been tested?
All checks are passing.
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).