Fix: Color editor discards colors with default name. #37496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra,
ellatrix and
mkaz
as code owners
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
force-pushed
the
fix/dont-discard-colors-with-default-name
branch
from
b25d330
to
73ce182
Compare
|
Size Change: +61 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jorgefilipecosta
changed the title
jorgefilipecosta
changed the title
glendaviesnz
approved these changes
Dec 19, 2021
jorgefilipecosta
deleted the
fix/dont-discard-colors-with-default-name
branch
tellthemachines
removed
the
Backport to WP Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #36940 we added a default name to colors in the custom color palette. It seems the user can just rely on that name and provide a color value but if that happens the color is discarded because there is no slug for that color. This situation makes it look like there is a bug and things are not working.
This PR updates the logic and now the user can use the default name and if the color is changed it is not discarded.
cc: @ramonjd
How has this been tested?
I went to the color palette.
I added a custom color keeping the default name of "Color x" and changing the color to red.
I pressed done and verified the color was not discarded.