Fix and enable remaining navigation block e2e tests #37437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Block] Navigation
talldan
commented
Dec 16, 2021
| @@ -564,125 +547,13 @@ describe( 'Navigation', () => { | |||
| expect( quickInserter ).toBeTruthy(); | |||
| } ); | |||
|
|
|||
| // The following tests are unstable, roughly around when https://github.com/WordPress/wordpress-develop/pull/1412 | |||
| // landed. The block manually tests well, so let's skip to unblock other PRs and immediately follow up. cc @vcanales | |||
| it.skip( 'loads frontend code only if the block is present', async () => { | |||
There was a problem hiding this comment.
I've divided this up into two tests.
talldan
commented
Dec 16, 2021
| expect( tagCount ).toBe( 1 ); | ||
| } ); | ||
|
|
||
| it.skip( 'loads frontend code only if responsiveness is turned on', async () => { |
There was a problem hiding this comment.
This is no longer true, so the test has been removed.
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
talldan
force-pushed
the
fix/remaining-navigation-e2e-tests
branch
from
9521576
to
fee3fb9
Compare
|
This should be ready for review now. |
getdave
approved these changes
Dec 17, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few navigation block tests were skipped, either due to being unstable or because they were temporarily skipped while the block underwent a lot of changes.
Now things are a bit more stable, it's a good time to bring these tests back.