Fix controlled blocks e2e tests after template part support from post editor #37333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
|
Code's looking good -- let's maybe just add a Changelog entry to the However, e2e tests are currently failing with a 500 error (in |
ntsekouras
commented
Dec 14, 2021
| @@ -173,19 +160,18 @@ describe( 'Multi-entity save flow', () => { | |||
| await page.keyboard.type( '...more title!' ); | |||
|
|
|||
| // Verify update button is enabled. | |||
| await page.waitForSelector( enabledSavePostSelector ); | |||
| const enabledSaveButton = await page.$( enabledSavePostSelector ); | |||
There was a problem hiding this comment.
There seems to be a problem here, although it was always passing locally 😄 . I'll need to investigate more
ntsekouras
force-pushed
the
fix/controlled-blocks-e2e-tests
branch
from
a957df1
to
528015f
Compare
ockham
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37327
Since these tests relied on the fact that we need to test a controlled block like
template part or reusable block, I've extractedcreateReusableBlockand made it an e2e util. It seems that it might be useful in general..