Site Editor: Hide the block appender in the Template Part editor #37213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +18 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 8, 2021
kevin940726
approved these changes
Dec 8, 2021
kevin940726
reviewed
Dec 8, 2021
| @@ -124,6 +124,7 @@ export default function BlockEditor( { setIsInserterOpen } ) { | |||
| <BlockList | |||
| className="edit-site-block-editor__block-list wp-site-blocks" | |||
| __experimentalLayout={ LAYOUT } | |||
| renderAppender={ isTemplatePart ? false : undefined } | |||
There was a problem hiding this comment.
Should we still render the appender if the template is empty? As stated in the original issue's title.
There was a problem hiding this comment.
If you remove all blocks, the default empty paragraph prompt appears:
This probably warrants some design exploration (it might be good to surface patterns more prominently here), and shouldn't hold up this PR.
There was a problem hiding this comment.
Yeah the paragraph appender will still appear. Agree it could use some love 🙂
There was a problem hiding this comment.
I think we can address that as a part of #28737, and this probably elevates the importance of looking in to that issue for 6.0.
|
This may be a separate issue but I noticed the height value applied to the canvas isn't being calculated correctly, and I see a scrollbar: scroll.mp4For reference, the body tag on my theme has a border, it seems this isn't factored in to the height calculation. |
|
@jameskoster: I might just link to your comment in #36141. Looks like there's a few weird things to do with canvas height we need to investigate. |
|
I wonder why this is only limited to template parts, it feels we can do so for the all the site editor maybe? Is there any discussion about this? |
|
@youknowriad There has been a lot of scattered discussion about the various inserters and I think the consensus is that we should remove this particular one in the Site Editor as well. Focus mode was prioritised though as that experience is more egregious. |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
added a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #36827.
Just a simple PR that hides the block appender in the Template Part editor.
I confirmed that the background colour of the Template Part editor is taken from Global Styles, so no action is required there.
On tall viewports, the height of the editor is greater than the height of the content which means there's a large bit of whitespace at the bottom. This is tracked separately in #36141.
How has this been tested?
Screenshots
Checklist:
*.native.jsfiles for terms that need renaming or removal).