Navigation: Enable even more compact setup state. #37089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +93 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
vcanales
reviewed
Dec 3, 2021
jasmussen
force-pushed
the
try/navigation-compact-setup-state
branch
from
721ba4d
to
10a7f3f
Compare
|
Thanks for the review. Based on your screenshot I thought I knew what the problem was (overflow) — but as it turns out, I can't reproduce. I'm seeing the blobs cropped (which is its own problem) but doesn't bleed out like you show. Are there additional steps to reproduce? Which theme did you use?
|
jasmussen
added
the
Backport to WP Beta/RC
Mamaduka
approved these changes
Dec 28, 2021
|
Thanks for the green check, I think it's important to land this one! The blobs being cut off is a failing of that concept, and I think we should remove them (#36858), but that likely won't make it to 5.9 at this point. |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37077.
This PR enables an even more compact setup state for when the block is used in very very narrow contexts. Shown in this GIF, a navigation block inside a 50% width column showing fewer buttons than the one outside:
Note that the code is a not as nice as it could be if we landed #36775. #36778 is also what I consider to be a more long term solution that both avoids layout shifts when selected, but also indicates the block could be used in a more preconfigured state.
How has this been tested?
Insert a navigation block in a thin column, and outside. Select it.
Checklist:
*.native.jsfiles for terms that need renaming or removal).