Update template controller unit test now that author support is in WP core #36987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
|
@talldan, I think we should also sync plugin unit tests with core one - WordPress/wordpress-develop#1967 (review). I just wanted to mention it here, but we can handle it separately. |
The source code also needs to be synced. The gutenberg code has fallen behind, which is concerning. I'll try to bring everything up to date in #36898 |
|
Going to merge this, the failing e2e test is unrelated (possibly intermittent, IDK), but at least this unblocks PHP tests. |
7 tasks
noisysocks
added
the
Backport to WP Beta/RC
noisysocks
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #36896 (comment) and #36896 (comment), the templates rest controller is in an unusual situation of using some PHP code from WordPress core and some from Gutenberg. (a situation that I'm looking to fix separately in #36898).
This resulted in the author feature implemented in #36896 not fully working until the supporting code landed in WordPress core. Now that it has landed there, the unit tests need updating again in Gutenberg since the author is now correctly assigned when saving.
How has this been tested?
Unit tests should pass.