Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/navigation blocks post processing after migration from menu items #36950

Merged
merged 6 commits into from
Dec 13, 2021
Merged

Add/navigation blocks post processing after migration from menu items #36950

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f9c989
add navigation.menuItemsToBlocks filter to postprocess blocks created…
adamziel Nov 29, 2021
1b53a2e
Add navigation_after_parse_blocks_from_menu_items filter
adamziel Nov 29, 2021
a0c2f19
Merge branch 'trunk' into add/navigation-blocks-post-processing-after…
adamziel Dec 8, 2021
24e79f5
Make the filter experimental
adamziel Dec 10, 2021
1b63aa3
Lint
adamziel Dec 10, 2021
4ffad70
Update menu-items-to-blocks.js
adamziel Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/navigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ function gutenberg_parse_blocks_from_menu_items( $menu_items, $menu_items_by_par
$blocks[] = $block;
}

return $blocks;
return apply_filters( 'navigation_after_parse_blocks_from_menu_items', $blocks, $menu_items );
draganescu marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
4 changes: 3 additions & 1 deletion packages/block-library/src/navigation/menu-items-to-blocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { sortBy } from 'lodash';
* WordPress dependencies
*/
import { createBlock, parse } from '@wordpress/blocks';
import { applyFilters } from '@wordpress/hooks';

/**
* Convert a flat menu item structure to a nested blocks structure.
Expand All @@ -21,7 +22,8 @@ export default function menuItemsToBlocks( menuItems ) {
}

const menuTree = createDataTree( menuItems );
return mapMenuItemsToBlocks( menuTree );
const blocks = mapMenuItemsToBlocks( menuTree );
return applyFilters( 'navigation.menuItemsToBlocks', blocks, menuItems );
draganescu marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down