Fix icon scaling. #36948
Merged
Fix icon scaling. #36948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
mtias
approved these changes
Nov 29, 2021
|
Size Change: +16 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
The vertical alignment seems different between the two? |
jasmussen
force-pushed
the
fix/icon-scaling
branch
from
5e7d47d
to
0970202
Compare
Good eye. As it turns out, this happens because in the editor, the icon is placed inside the I'd like to fix this separately. In investigating this, by the way, I noticed a duplicate |
This seems probably related to |
jasmussen
force-pushed
the
fix/icon-scaling
branch
from
0970202
to
ae1fe74
Compare
noisysocks
pushed a commit
that referenced
this pull request
Nov 30, 2021
noisysocks
removed
the
Backport to WP Beta/RC
|
Following up on vertical alignment in #37003. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36923. Followup to #36714. The dropdown menu icon should scale with the font size. The previous fix failed to include the frontend. This PR addresses that. Editor:
Frontend:
How has this been tested?
Insert a navigation menu with submenus, change the font size, verify the arrow icon looks the same size in editor and frontend.
Checklist:
*.native.jsfiles for terms that need renaming or removal).