Site Editor: Allow editing custom template title #36933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
Nov 28, 2021
| > | ||
| { title } | ||
| </Heading> | ||
| { template.is_custom ? ( |
There was a problem hiding this comment.
Should I extract this into the custom util method, similar to isTemplateRevertable and isTemplateRemovable?
|
Size Change: +131 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
I'm not sure if this is the right place to place a text input to. It isn't a form and might have accessibility concerns if not careful. Could it be possible to implement this in the template sidebar instead?
@jameskoster WDYT? Edit: Oh I see it's mentioned in the original issue now. NVM |
Mamaduka
force-pushed
the
add/tempalte-details-edit-title
branch
from
350ef42
to
3f2f423
Compare
7 tasks
Just to clarify for anyone reading this after-the-fact: custom templates can already be renamed in the post editor:
We're migrating that UX to the site editor for now, and will make this (and other template meta) editable in the Inspector later. |
|
Added fallback to slug logic as we discussed here - #36947 (comment) |
Mamaduka
force-pushed
the
add/tempalte-details-edit-title
branch
from
a03db96
to
ff817bb
Compare
|
@jameskoster, should we merge this? |
jameskoster
approved these changes
Nov 29, 2021
noisysocks
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Site Editor: Allow editing custom template title * Fallback to slug
noisysocks
removed
the
Backport to WP Beta/RC
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds a way to edit custom template titles in the Site Editor. UI matches edit title component from Template Mode.
Note: Currently, you can only edit user-created template titles that aren't in the WP template hierarchy - e.g., Index, Single, etc.
Closes #36773.
How has this been tested?
TextControlto edit the template title.Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).