Add 'Clear customizations' button to template list page #36802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
Backport to WP Beta/RC
talldan
changed the title
talldan
commented
Nov 24, 2021
| <MenuItem | ||
| info={ __( 'Restore template to theme default' ) } | ||
| onClick={ () => { | ||
| revertTemplate( template ); |
There was a problem hiding this comment.
The main outstanding issue seems to be that revertTemplate doesn't actually save the edited entity records to complete the reversion. The listing page doesn't update because of that.
It's really designed for use in the editor where there's a separate save button. It also treats the revert as something that can be undone. That may be more difficult to achieve here if we have to save the changes.
The options here:
- Don't use this action, create an entirely different action or make the revert code local to this component
- Customize
revertTemplateso that it accepts additional params to make it work on this screen - Something else that I haven't thought of
There was a problem hiding this comment.
We could, not that it's preferred, add the entity saving workflow to this screen too. I think it would look weird though.
Could we add an optional option force: true to indicate that it should save immediately after edited? If that doesn't work we can create a separate action for it.
There was a problem hiding this comment.
I implemented something similar to force: true but I didn't like how it means that passing an argument completely changes the behaviour of the action.
Ideally I'd split revertTemplate up into two functions—one that saves, one that doesn't—and have them both call into a private action which does the entity editing bits. This is really difficult to do unless we change edit-site to use thunks, though.
So instead I went with e9e7ede which has the button immediately save the entity after reverting. I added a allowUndo option so that the success notice, when we implement notices, doesn't allow the user to undo something that's been already saved.
There was a problem hiding this comment.
I think we should also inform users that this is an irreversible action.
There was a problem hiding this comment.
I think we should also inform users that this is an irreversible action.
I think let's follow up on that. I see "Ability to undo an action" on the list (#36597). We have the same problem with the Remove action.
|
Size Change: -33 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
38 tasks
noisysocks
added
[Feature] Site Editor
|
I guess @talldan and I ended up pairing on this so just need a ✅ from @jameskoster and should be good to merge. |
|
I think there are some failing tests because the new I can patch that up in a bit. |
jameskoster
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Approving because it works, but we'll certainly need a Snackbar confirmation. I suppose we can tackle that in #36808.
I didn't get round to this, but should be a simple fix. |
7 tasks
|
@talldan, I will look into and fix the failing e2e test. |
|
Thanks everyone. |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
added a commit
that referenced
this pull request
Nov 29, 2021
* Add 'Clear customizations' button * Save entity after reverting it * Correctly 'allowUndo' default Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #36611.
Adds a Clear customizations button to the dropdown in the Site Editor list view.
Kapture.2021-11-24.at.16.59.05.mp4
How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).