Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try always generating navigation post title #36760

Merged
merged 13 commits into from Nov 24, 2021
Merged

Try always generating navigation post title #36760

merged 13 commits into from Nov 24, 2021

Commits on Nov 24, 2021

  1. Try always generating navigation title

    @tellthemachines @adamziel
    tellthemachines authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    c15a377 View commit details
    Browse the repository at this point in the history

  2. Show placeholder preview

    @tellthemachines @adamziel
    tellthemachines authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    acc5653 View commit details
    Browse the repository at this point in the history

  3. Add useCreateNavigationMenu

    @adamziel
    adamziel committed Nov 24, 2021
    Copy the full SHA
    0af669e View commit details
    Browse the repository at this point in the history

  4. Update packages/block-library/src/navigation/edit/use-default-navigat… 

    …ion-title.js
    @adamziel
    adamziel committed Nov 24, 2021
    Copy the full SHA
    6d31ca9 View commit details
    Browse the repository at this point in the history

  5. Fix placeholder and remove unecessary logic.

    @tellthemachines @adamziel
    tellthemachines authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    eb80d02 View commit details
    Browse the repository at this point in the history

  6. Pass clientId to placeholder.

    @tellthemachines @adamziel
    tellthemachines authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    7f5011d View commit details
    Browse the repository at this point in the history

  7. Reset inner blocks when creating new menu

    @getdave @adamziel
    getdave authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    f4b4bc4 View commit details
    Browse the repository at this point in the history

  8. Only consider published Navigations as valid

    @getdave @adamziel
    getdave authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    2219fa5 View commit details
    Browse the repository at this point in the history

  9. Correct bug with checking status of Nav post

    @getdave @adamziel
    getdave authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    1263ad3 View commit details
    Browse the repository at this point in the history

  10. UX to allow creating new menu if associated Nav post not found 

    Previously you could get into an error state if the Nav block referenced a Nav Post which had been deleted. You could not recover from this as the UI provided no way to "start over". This addition affords that ability.
    @getdave @adamziel
    getdave authored and adamziel committed Nov 24, 2021
    Copy the full SHA
    4808aaf View commit details
    Browse the repository at this point in the history

  11. Switch to useGenerateDefaultNavigationTitle

    @adamziel
    adamziel committed Nov 24, 2021
    Copy the full SHA
    1885a87 View commit details
    Browse the repository at this point in the history

  12. Wrap createNewMenu in useCallback

    @adamziel
    adamziel committed Nov 24, 2021
    Copy the full SHA
    4317c76 View commit details
    Browse the repository at this point in the history

  13. Rename createNewMenu to startWithEmptyMenu

    @adamziel
    adamziel committed Nov 24, 2021
    Copy the full SHA
    407af14 View commit details
    Browse the repository at this point in the history