Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Migrate global styles user database data on the rest endpoint #36747

Merged
merged 2 commits into from Nov 23, 2021
Merged

Update: Migrate global styles user database data on the rest endpoint #36747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd2881
Update: Automatically migrate global styles user database data on the…
jorgefilipecosta Nov 22, 2021
848f97b
Fix lint issues
oandregal Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/compat/wordpress-5.9/class-gutenberg-rest-global-styles-controller.php
View file
Open in desktop
Expand Up @@ -216,8 +216,12 @@ protected function prepare_item_for_database( $request ) {
* @return WP_REST_Response $data
*/
public function prepare_item_for_response( $post, $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
$config = json_decode( $post->post_content, true );
$is_global_styles_user_theme_json = isset( $config['isGlobalStylesUserThemeJSON'] ) && true === $config['isGlobalStylesUserThemeJSON'];
$raw_config = json_decode( $post->post_content, true );
$is_global_styles_user_theme_json = isset( $raw_config['isGlobalStylesUserThemeJSON'] ) && true === $raw_config['isGlobalStylesUserThemeJSON'];
$config;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be set to something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not I'm just instantiating the variable because it is used outside the if condition where we set the variable.

if( $is_global_styles_user_theme_json ) {
$config = ( new WP_Theme_JSON_Gutenberg( $raw_config, 'user' ) )->get_raw_data();
}

$fields = $this->get_fields_for_response( $request );

Expand Down