Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use first non-empty Nav post as primary fallback for Nav block #36740

Merged
merged 16 commits into from Nov 24, 2021
Merged

Use first non-empty Nav post as primary fallback for Nav block #36740

merged 16 commits into from Nov 24, 2021

Commits on Nov 23, 2021

  1. Use non-empty Nav post as fallback

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    33995bc View commit details
    Browse the repository at this point in the history

  2. Remove code duplication 

    Addresses #36740 (comment)
    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    3a4e549 View commit details
    Browse the repository at this point in the history

  3. Extract finding non empty nav block to function

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    098f453 View commit details
    Browse the repository at this point in the history

  4. Extract process of getting fallback to dedicated function

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    d466c2b View commit details
    Browse the repository at this point in the history

  5. Apply block prefix to functions

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    5e75bb5 View commit details
    Browse the repository at this point in the history

  6. Add additional safety check around parsing Nav blocks

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    d952588 View commit details
    Browse the repository at this point in the history

  7. Extract function for removing null blocks and apply

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    d15df93 View commit details
    Browse the repository at this point in the history

  8. Check for empty parsed Nav blocks

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    cdaaf5e View commit details
    Browse the repository at this point in the history

  9. Improve function comment 

    Addresses #36740 (comment)
    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    d6d1e25 View commit details
    Browse the repository at this point in the history

  10. Amend ordering params to approximate current wp_nav_menus behaviour

    @getdave
    getdave committed Nov 23, 2021
    Copy the full SHA
    2831ff3 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Fetch Nav posts in query rather than filtering in memory 

    Implements suggestion from #36740 (comment)
    @getdave
    getdave committed Nov 24, 2021
    Copy the full SHA
    5f8263b View commit details
    Browse the repository at this point in the history

  2. Improve comments

    @getdave
    getdave committed Nov 24, 2021
    Copy the full SHA
    7ff837e View commit details
    Browse the repository at this point in the history

  3. Spacing

    @getdave
    getdave committed Nov 24, 2021
    Copy the full SHA
    81bf76a View commit details
    Browse the repository at this point in the history

  4. Limit Nav Posts query to a single item 

    Co-authored-by: Adam Zielinski <adam@adamziel.com>
    @getdave @adamziel
    getdave and adamziel committed Nov 24, 2021
    Copy the full SHA
    ead6d3c View commit details
    Browse the repository at this point in the history

  5. Fix linting

    @getdave
    getdave committed Nov 24, 2021
    Copy the full SHA
    b0c80aa View commit details
    Browse the repository at this point in the history

  6. Improve function naming 

    Co-authored-by: Adam Zielinski <adam@adamziel.com>
    @getdave @adamziel
    getdave and adamziel committed Nov 24, 2021
    Copy the full SHA
    4dbb220 View commit details
    Browse the repository at this point in the history