Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand block list tree on selection. #35817

Merged
merged 15 commits into from
Feb 21, 2022
Merged

Expand block list tree on selection. #35817

merged 15 commits into from
Feb 21, 2022

Commits on Feb 20, 2022

  1. Check element ref for active document so we can try to expand the lis… 

    …t only when a block is selected outside the block list.

Using an `useEffect` to loop through parent nodes, and expand them when necessary.
    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    7228725 View commit details
    Browse the repository at this point in the history

  2. Renamed parent client id array to selectedBlockParentClientIds

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    3016c4f View commit details
    Browse the repository at this point in the history

  3. Creating a new action type, so we can update the state with one actio… 

    …n call.
    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    502c13c View commit details
    Browse the repository at this point in the history

  4. Refactoring reducer to accept an array of clientIds.

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    dd830fc View commit details
    Browse the repository at this point in the history

  5. Only try to expand nested branch items where there are parent ids

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    ce53172 View commit details
    Browse the repository at this point in the history

  6. This commit can potentially be discarded as it might be worth explori… 

    …ng in a new PR.

Here we're calculating the top scroll position of the selected block.
    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    629e78a View commit details
    Browse the repository at this point in the history

  7. Tracking the selected block in the tree and checking it against the s… 

    …elected block *should* inform us that a block has been selected elsewhere, e.g., the editor.

When we know this we can execute the hook logic that expands and scrolls to the selected element in the tree if a block is selected elsewhere.
Removing hasFocus.
    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    10ce687 View commit details
    Browse the repository at this point in the history

  8. Extracted scroll and expand logic to hook

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    2f2ad46 View commit details
    Browse the repository at this point in the history

  9. Revert scroll to logic to be performed in another PR.

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    8f025c5 View commit details
    Browse the repository at this point in the history

  10. Revert export

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    f0eb982 View commit details
    Browse the repository at this point in the history

  11. Adding e2e test

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    4049d45 View commit details
    Browse the repository at this point in the history

  12. Forgot to pass on the correct args to updateBlockSelection()

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    874a457 View commit details
    Browse the repository at this point in the history

  13. Focussing on the cover block before testing the expand element.

    @ramonjd
    ramonjd committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    33cf482 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Renaming function and file name to make it clearer to folks what it d… 

    …oes.
    @ramonjd
    ramonjd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    30f65ee View commit details
    Browse the repository at this point in the history

  2. Linto!

    @ramonjd
    ramonjd committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    d1a2731 View commit details
    Browse the repository at this point in the history