Block Supports: Add panel specific className #35793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
the
CSS Styling
|
Size Change: +10 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Tests well for dimension and border. I couldn't cleanly rebase or merge this PR on top of Color Block Support: Switch to ToolsPanel for displaying UI #34027, or the other way around unfortunately. It looks like that PR needs a rebase itself. So wasn't able to reliably test the color panel. Seeing as it's not yet merged I guess it's okay?
Conceptually, I think adding specific classnames for grouped ToolsPanels is okay, seeing as there's a precedent for passing custom Is it something that we'd continue to want to do in the future? I can't tell. I don't think the desire to customize the internals of individual panels is going to go away though. |
ramonjd
approved these changes
Oct 20, 2021
ramonjd
reviewed
Oct 20, 2021
packages/block-editor/src/components/inspector-controls/block-support-tools-panel.js
Show resolved
Hide resolved
Between when #34027 was created and now a lot has changed. I have rebased it locally and am working on resolving conflicts. In particular, the Global Styles sidebar has changed plenty. It now uses an updated navigation component as well as a new approach to getting and setting global styles. The same goes for the other block support panel PRs switching to the I'm not sure that these panels in the global styles need to be updated now but I'm guessing consistency between the global styles and block editor inspector controls is still desirable. Either way, given we shouldn't target hardcoded class names directly within the
Even when our components are updated to leverage the context system and Emotion for styling, I believe there'll be value in being able to target these panels via CSS. While still experimental, soon enough, we'll be allowing controls to be injected into these block support panels via SlotFill. I can definitely see those ad hoc controls benefiting from the new class names. |
|
To help progress the other PRs switching the block supports to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Description
This adds a
classNamespecific to each grouped inspector controls slot. It allows different block supports to override some component styles within theToolsPaneluntil those components are migrated to the new context system.How has this been tested?
Manually.
dimensions-block-support-panelclass.Screenshots
Types of changes
Enhancement.
Checklist:
*.native.jsfiles for terms that need renaming or removal).