Cover block: Change dimRatio to 50 if media added and dimRatio is set to 100 #35789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent background color obscuring image
glendaviesnz
added
the
[Block] Cover
|
Size Change: +25 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Merged
7 tasks
antonis
reviewed
Oct 20, 2021
There was a problem hiding this comment.
Hey @glendaviesnz 👋
Thank you for fixing this so quickly. The solution LGTM and works as expected 🎉
I've made a small change with #35792 to make the PR to work on mobile.
aaronrobertshaw
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
LGTM 👍
I could replicate the issue on trunk. After applying this PR the overlay's opacity is reduced revealing the newly added media.
The only quirk I experienced was the change in font color going from white to black however I believe that is unrelated to this PR and shouldn't block it.
geriux
approved these changes
Oct 20, 2021
antonis
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Hey @glendaviesnz 👋
after @geriux's approval I tool the liberty to merge the mobile fix into this PR. Everything works as expected now on mobile too 🎉
|
Hey @glendaviesnz I'll merge this PR so we can move forward with the beta fix of the app. 🙇 |
geriux
added a commit
that referenced
this pull request
Oct 21, 2021
* Release script: Update react-native-editor version to 1.64.0 * Release script: Update with changes from 'npm run core preios' * Update Changelog * Release script: Update react-native-editor version to 1.64.1 * Release script: Update with changes from 'npm run core preios' * Fix updating the block list after block removal (#35721) * Cover block: Change dimRatio to 50 if media added and dimRatio is set to 100 (#35789) * Change opacity to 50 if media added and opacity is set to 100 to prevent background color obscuring image * Fixes cover opacity bug on mobile (#35792) Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> * Mobile - Update Changelog Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the dimRation to 50 if media added and dimRatio is set to 100 to prevent background color obscuring image
Potential fix for: #35766
To test
Screenshots
Before:
After: