Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child theme.json: update test to better capture that childs can update single parts in isolation #35759

Merged
merged 1 commit into from Oct 20, 2021

Conversation

oandregal
Copy link
Member

Follow-up to #35459

Update so we test that single parts can be overridden by the child while untouched parent sections remain the same.

@oandregal oandregal self-assigned this Oct 19, 2021
@oandregal oandregal added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Full Site Editing [Type] Code Quality Issues or PRs that relate to code quality labels Oct 19, 2021
@Mamaduka
Copy link
Member

@oandregal, you might want to rebase on the latest trunk. The React Native iOS issue got fixed recently.

@oandregal
Copy link
Member Author

I already did but it seems it's a different error in this case? cc @geriux

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing for me locally 👍

@geriux
Copy link
Member

geriux commented Oct 19, 2021

I already did but it seems it's a different error in this case? cc @geriux

Thanks for the ping, I restarted the job but it failed again, I'll investigate this. 👍

@oandregal
Copy link
Member Author

Rebased again to see if that clears the new error out.

@oandregal
Copy link
Member Author

ok, got a new one:

Run sudo xcode-select --switch /Applications/Xcode_12.5.1.app
xcode-select: error: invalid developer directory '/Applications/Xcode_12.5.1.app'
Error: Process completed with exit code 1.

which I also see happening in trunk for a commit after the XCode update https://github.com/WordPress/gutenberg/runs/3940696898

@geriux
Copy link
Member

geriux commented Oct 19, 2021

ok, got a new one:

Run sudo xcode-select --switch /Applications/Xcode_12.5.1.app
xcode-select: error: invalid developer directory '/Applications/Xcode_12.5.1.app'
Error: Process completed with exit code 1.

which I also see happening in trunk for a commit after the XCode update https://github.com/WordPress/gutenberg/runs/3940696898

Sorry for that, it looks like the propagation of the Github action changes are taking more than expected so we are hoping to fix it in this PR.

@oandregal oandregal merged commit 39be23f into trunk Oct 20, 2021
@oandregal oandregal deleted the update/test-theme-json-child branch October 20, 2021 09:54
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants