Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor List View: use anchor elements instead of buttons #35655

Merged
merged 8 commits into from Nov 25, 2021
Merged

Block Editor List View: use anchor elements instead of buttons #35655

merged 8 commits into from Nov 25, 2021

Commits on Nov 17, 2021

  1. Switching from using Button to an anchor tags for List View tree items.

    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    2c8eb79 View commit details
    Browse the repository at this point in the history

  2. Let's not use the HTML anchor here as it's not reliable in the editor.

    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    c5ec335 View commit details
    Browse the repository at this point in the history

  3. Updating e2e test selectors

    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    6e52396 View commit details
    Browse the repository at this point in the history

  4. Updating e2e test selectors

    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    e3fb45b View commit details
    Browse the repository at this point in the history

  5. The href attribute triggers the browser's native HTML drag operations. 

    When the link is dragged, the element's outerHTML is set in DataTransfer object as text/html.
We need to clear any HTML drag data to prevent `pasteHandler` from calling inside `useOnBlockDrop`.
    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    a074b96 View commit details
    Browse the repository at this point in the history

  6. Using the Button's component's anchor tag, given that we're passing a… 

    …n href.

This allows us to remove the custom CSS for the native anchor element.
    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    e9d17d7 View commit details
    Browse the repository at this point in the history

  7. Adding key event handlers for space and enter. This is to persist but… 

    …ton element behaviour, even though we're switching to an anchor element.

Forcing a tabIndex of `0` so the anchor elements are tabbable.
    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    4099726 View commit details
    Browse the repository at this point in the history

  8. Reverting back to Space key since we've added a keyboard event for Sp… 

    …ace.

Reinstate tabIndex
    @ramonjd
    ramonjd committed Nov 17, 2021
    Copy the full SHA
    48e288c View commit details
    Browse the repository at this point in the history