Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic example to site-title block #35590

Merged
merged 1 commit into from Oct 14, 2021
Merged

Add basic example to site-title block #35590

merged 1 commit into from Oct 14, 2021

Conversation

fabiankaegy
Copy link
Member

@fabiankaegy fabiankaegy commented Oct 13, 2021 •
edited

Description

Add a basic example to the core/site-title block.

Part of #30029
Similar to #35588

How has this been tested?

Locally using the bundles wp-env environment

Screenshots

State when no Title has been defined jet:

Screen Shot 2021-10-13 at 13 59 07

State once a Site Title has been defined:

Screen Shot 2021-10-13 at 14 02 27

Types of changes

New feature: Add an example to the site title block to add a live preview in the inserter

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Site Title Affects the Site Title Block labels Oct 13, 2021
@fabiankaegy fabiankaegy self-assigned this Oct 13, 2021
@fabiankaegy fabiankaegy mentioned this pull request Oct 13, 2021
Open
18 tasks
Mamaduka
Mamaduka approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks, @fabiankaegy.

@fabiankaegy fabiankaegy merged commit 82e59df into trunk Oct 14, 2021
@fabiankaegy fabiankaegy deleted the feature/improve-example-of-site-title-block branch October 14, 2021 05:57
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 14, 2021
@jasmussen jasmussen mentioned this pull request Oct 14, 2021
Merged
7 tasks
@Mamaduka Mamaduka mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mtias mtias Awaiting requested review from mtias

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees

@fabiankaegy fabiankaegy

Labels
[Block] Site Title Affects the Site Title Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabiankaegy @Mamaduka