Polish logos only style. #35586
Merged
Polish logos only style. #35586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Block] Social
|
Size Change: +130 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
This tested well for me, and with this patch applied the logo only option displayed as expected in editor and front-end:
Editor:
Front end:
I also tested adding gap support to the block via theme.json as enabled in #35236, and the gap support still behaved as expected with this patch in place.
ramonjd
approved these changes
Oct 14, 2021
|
Thank you for the reviews folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35581.
This PR revisits the logos only style for social links. The block now uses
gapto space things out, and some of the original metrics appear to have been lost in the shuffle. This PR tweaks so the logo-only versions are again a little bigger:Before:
After:
How has this been tested?
Observe that the logos only style for social links doesn't space the blocks out too wide, and that the icons are a little bigger than in their circle style.
Here's some test content:
Checklist:
*.native.jsfiles for terms that need renaming or removal).