Add fontStyle control to Site Tagline block #35507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
kjellr
commented
Oct 11, 2021
| "__experimentalTextTransform": true, | ||
| "__experimentalFontStyle": true, | ||
| "__experimentalFontWeight": true, |
There was a problem hiding this comment.
I moved this one down just so that the order these are listed is in sync with the Site Title block.
jasmussen
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the block in sync with the Site Title block. Since they're often used in tandem, I think it makes sense to include this control visible for both.
Many of the Twenty Twenty-Two header mockups use an italic site tagline, but in
trunk(where there's currently just a "Weight" dropdown) it's impossible to make that happen via the UI.To test:
Appearanceitem in the sidebar, with both font weight and font style options.Screenshot:
(Note that the "Weight" control changes to an "Appearance" control on the right)