Media Placeholder: make component easier to read and reduce required … #35482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Type] Enhancement
|
Size Change: +59 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
I'm excited about this. @gwwar, please let me know when I can help with testing this PR. |
|
Putting this on hold for a while, since I'll be out on a 3-month sabbatical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Not ready to be looked at.
Follow up to #35397 and potentially fixes #22273
I'll be playing around with a few ideas to make the MediaPlaceholder easier to reason about. We'll need to balance:
editor.MediaPlaceholderfilterI've also noticed that this file is a bit difficult to read. Part of this is from prioritizing code reuse (reused render functions) over composition or more declarative components. This probably happened naturally over time, but I think it's worth revisiting.