Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List: Show empty placeholder if no items #35441

Merged
merged 4 commits into from Oct 8, 2021
Merged

Page List: Show empty placeholder if no items #35441

merged 4 commits into from Oct 8, 2021

Commits on Oct 7, 2021

  1. Add empty response placeholder

    @mkaz
    mkaz committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    69436d1 View commit details
    Browse the repository at this point in the history

  2. Return early if no top level pages

    @mkaz
    mkaz committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    87c488c View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Simplify placeholder to just span and text

    @mkaz
    mkaz committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    890ca11 View commit details
    Browse the repository at this point in the history

  2. Move the check for empty pages up to all_pages 

    This makes it more clear and bails out even earlier.
    @mkaz
    mkaz committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    03b4f6b View commit details
    Browse the repository at this point in the history