Site Logo: Remove "Reset" button icon #35434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -18 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
stacimc
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Thanks for the quick follow-up. This tested well ✔️
it turns out that MediaReplaceFlow doesn't use the DropdownMenu component, and we don't get all styling out of the box.
I'm not sure we want to duplicate all those styles just for a single menu item.
Sounds reasonable to me. Having the Reset button in its own menu group would be nice, but not a necessity IMO. LGTM!
|
Thank you for the reviews, @stacimc and @andrewserong. |
This was referenced Oct 22, 2023
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #35372 (comment).
PR removes the reset button icon.
I tried group menu items as @jasmussen suggested. But it turns out that
MediaReplaceFlowdoesn't use theDropdownMenucomponent, and we don't get all styling out of the box.I'm not sure we want to duplicate all those styles just for a single menu item.
How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).