Featured Image: Center placeholder chip contents #35417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Post Featured Image
|
Size Change: -9 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
Welcome to the department of subtleties 👌
The fix works well:
Due to your line height comment I also tested whether it was subject to any line height bleed. It isn't, because it's set to zero on the parent, so this is the right fix. Nice.
Unrelated to this PR, though, I noticed the featured image in the post editor looks like this:
I do wonder whether that block should even be available in the individual post editor, though, seems like there are arguments for and against.
I'm not sure about this, but it makes sense to keep it for now since other post blocks are available. I also realized that one could not Reset/Remove the featured image using the block. Instead, you have to go to the Document sidebar to do this. Do you think the "Reset" menu item (similar to #35372) would also be beneficial here? |
ntsekouras
approved these changes
Oct 7, 2021
This had been implemented and then removed here: #27291 . Things like that change often though 😄 |
|
@ntsekouras, what do you think should we add it back and make it part of the media replacement workflow? Site Logo Block Example
|
|
TBH I'm not sure. I was the one that had added in the first place before removing it 😄 . Maybe @mcsf , @mtias or @jameskoster could share their thoughts if they think we should bring it back.. |
|
The replace pattern for both site logo and images are becoming nicely established. The original reason for not having a "Clear" action made good sense: what is its use if you can just delete the block? That still seems valid enough, honestly, and probably why it doesn't exist for the Image block either. It feels different for the Site Logo, though, since it saves at the theme level, and therefore needs a way to clear it at the theme level. |
|
The same argument can be made for the Featured Image block since data is also saved on post level (in meta). Removing block doesn't clear the meta field. |
|
Oh you're right, deleting the block doesn't remove the featured image. Might make sense then after all. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly aligns Featured Image placeholder chip contents.
The bug might be hard to spot if the paragraph element has
line-heightapplied. However, the issue became more visible after #35273.Closes #35297.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).