Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: enable slash inserter for heading, list, and quote #35360

Merged
merged 1 commit into from Oct 6, 2021

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Oct 5, 2021

Follow up to #35196, this enables the slash inserter in the heading, list and quote blocks. Changes here provide folks more ways to transform a block. Do the blocks here feel like good matches for the slash inserter? Are there any other blocks we'd like to enable the slash inserter for?

CleanShot.2021-10-05.at.09.19.36.mp4

Testing Instructions

  • Try adding a heading block
  • Press /. The slash inserter should appear.
  • Further typing should narrow down block selections. Pressing enter or an option should replace the block entirely with the chosen block.
  • Repeat testing for the list and quote blocks.
  • Verify that these transformations work in the Post, Site and Widget editors.

@gwwar gwwar added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels Oct 5, 2021
@gwwar gwwar requested a review from ajitbohra as a code owner October 5, 2021 16:27
@gwwar gwwar self-assigned this Oct 5, 2021
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! It is working well in my test.

@gwwar
Copy link
Contributor Author

gwwar commented Oct 6, 2021

Thanks for the review @carolinan! I'll try landing this and we can see if folks had any feedback. This one is pretty easy to turn off again if we need to do so.

@gwwar gwwar merged commit 5c9e84d into trunk Oct 6, 2021
@gwwar gwwar deleted the try/slash-inserter-text-blocks branch October 6, 2021 18:23
@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants