Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Content Block: Add typography, color and padding support #35183

Merged
merged 14 commits into from Oct 20, 2021
Merged

Comment Content Block: Add typography, color and padding support #35183

merged 14 commits into from Oct 20, 2021

Commits on Oct 19, 2021

  1. Comment Content Block: add more supports settings 

    Settings are:
* Typography and color settings (same as the Paragraph block)
* Layout settings (same as Post Content block)
    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    101994e View commit details
    Browse the repository at this point in the history

  2. Comment Content: Add block icon

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    4d87f07 View commit details
    Browse the repository at this point in the history

  3. Comment Content: Show placeholder when no context

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    697e778 View commit details
    Browse the repository at this point in the history

  4. Comment Content: Add jsdoc to edit component

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    105e488 View commit details
    Browse the repository at this point in the history

  5. Comment Content: Remove the layout setting

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    202288f View commit details
    Browse the repository at this point in the history

  6. Comment Content: Fix path props in icon

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    10dfbd8 View commit details
    Browse the repository at this point in the history

  7. Comment Content: Check if the comment is ready

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    813fcc3 View commit details
    Browse the repository at this point in the history

  8. Comment Content: Replace loading message with placeholder

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a9d6214 View commit details
    Browse the repository at this point in the history

  9. Comment Content: Support for textAlign attribute 

    I've also removed some cases that I think
should be handled in the parent block:
- When the comment is not ready yet
- When the comment does not exist
    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    83fcd22 View commit details
    Browse the repository at this point in the history

  10. Comment Content: Add padding support

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    ec40891 View commit details
    Browse the repository at this point in the history

  11. Comment Content: Add more typography settings 

    Added experimental settings for changing
- Font family
- Font weight
- Font style
- Text transform
- Letter spacing
    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    a776ca8 View commit details
    Browse the repository at this point in the history

  12. Comment Content: Remove unnecessary comments

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    13c61e6 View commit details
    Browse the repository at this point in the history

  13. Icons: Add post prefix to Comment Content icon

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    15bb5a6 View commit details
    Browse the repository at this point in the history

  14. Comment Content: Show block name as placeholder

    @DAreRodz
    DAreRodz committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    1fa7d39 View commit details
    Browse the repository at this point in the history