Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover block: Allow setting the height from the placeholder state. #35068

Merged
merged 9 commits into from Oct 13, 2021
Merged

Cover block: Allow setting the height from the placeholder state. #35068

merged 9 commits into from Oct 13, 2021

Commits on Oct 10, 2021

  1. initial commit

    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    fe6ddd6 View commit details
    Browse the repository at this point in the history

  2. Added some copy.

    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    d3cce6c View commit details
    Browse the repository at this point in the history

  3. Ensure that the resizeable placeholder has a consistent background co… 

    …lor (white) and border.
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    6e18643 View commit details
    Browse the repository at this point in the history

  4. Experiment to add vertical classes to the placeholder and use it to d… 

    …etermine the min-height of the resizeable placeholder.
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    137e17c View commit details
    Browse the repository at this point in the history

  5. limit the resize behaviour to is-large placeholders 

    Reverting changes to the Placeholder `useResizeObserver` since it was a test.
limit the resize behaviour to `is-large` placeholders
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    d24a05a View commit details
    Browse the repository at this point in the history

  6. Ensure the placeholder takes up the maximium available width set by t… 

    …he containing block
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    fb0ec6e View commit details
    Browse the repository at this point in the history

  7. We need to reshuffle the order of the elements to ensure that: 

    - a user can interact with the placeholder controls
- we can target the resizer as a sibling of `.components-placeholder.is-large`

Also cleaning up the CSS and removing unused styles.
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    fb8998b View commit details
    Browse the repository at this point in the history

  8. Bumping min-height of is-large placeholder resizer down to 240px

    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    eb6cfe3 View commit details
    Browse the repository at this point in the history

  9. Because we removed minHeight={ COVER_MIN_HEIGHT } on the resizeable… 

    … container so that our changes in editor.scss take precedence, we have to reinstate the COVER_MIN_HEIGHT of 50px now via css
    @ramonjd
    ramonjd committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    ec445b7 View commit details
    Browse the repository at this point in the history