Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: add new patterns #35063

Closed
wants to merge 1 commit into from
Closed

Navigation: add new patterns #35063

wants to merge 1 commit into from

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Sep 22, 2021

A small part of #34041 and #33091

It's time to start allowing initial states for navigation to be pattern-driven. A pattern should be able to express whatever layout they need while making it easy to be replaced by user content. This ranges from using "page list" for cases that are more straightforward, to using individual page items for composition that require careful placement of items. A user should be able to choose what page is assigned to a page item placeholder.

Changes here allow us to use a label as placeholder text instead of "Select Page". This makes patterns more visually interesting and lets users more quickly pick out useful patterns.

Since folks may find multiple ways of things, I also added a few simple patterns to demonstrate features of the navigation block that might not be apparent to folks at first glance.

Let me know if there's a better spot for these.

CleanShot.2021-09-22.at.14.30.38.mp4

Feedback/Questions

  • Without a prompt is it clear that folks know what happens when an item has a wavy line?
  • Are navigation patterns (outside of site header) patterns useful? Is there a better spot for these.
  • I think it's a good exercise to try building some more experimental menu examples like the following image. However it may more sense in a theme context. Any good candidates that I could explore in a follow up?

123940293-4f625480-d999-11eb-8e77-d1882cec8cd7-1

@gwwar gwwar self-assigned this Sep 22, 2021
@gwwar gwwar added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Sep 22, 2021
@github-actions
Copy link

Size Change: +8 B (0%)

Total Size: 1.06 MB

Filename Size Change
build/block-library/index.min.js 147 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 931 B
build/admin-manifest/index.min.js 1.09 kB
build/annotations/index.min.js 2.7 kB
build/api-fetch/index.min.js 2.19 kB
build/autop/index.min.js 2.08 kB
build/blob/index.min.js 459 B
build/block-directory/index.min.js 6.2 kB
build/block-directory/style-rtl.css 1.01 kB
build/block-directory/style.css 1.01 kB
build/block-editor/default-editor-styles-rtl.css 378 B
build/block-editor/default-editor-styles.css 378 B
build/block-editor/index.min.js 134 kB
build/block-editor/style-rtl.css 13.9 kB
build/block-editor/style.css 13.8 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 111 B
build/block-library/blocks/audio/style.css 111 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 474 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/button/style-rtl.css 600 B
build/block-library/blocks/button/style.css 600 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/buttons/style-rtl.css 370 B
build/block-library/blocks/buttons/style.css 370 B
build/block-library/blocks/calendar/style-rtl.css 207 B
build/block-library/blocks/calendar/style.css 207 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 206 B
build/block-library/blocks/columns/editor.css 205 B
build/block-library/blocks/columns/style-rtl.css 497 B
build/block-library/blocks/columns/style.css 496 B
build/block-library/blocks/cover/editor-rtl.css 666 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/cover/style-rtl.css 1.23 kB
build/block-library/blocks/cover/style.css 1.23 kB
build/block-library/blocks/embed/editor-rtl.css 488 B
build/block-library/blocks/embed/editor.css 488 B
build/block-library/blocks/embed/style-rtl.css 417 B
build/block-library/blocks/embed/style.css 417 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 322 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 983 B
build/block-library/blocks/gallery/editor.css 988 B
build/block-library/blocks/gallery/style-rtl.css 1.6 kB
build/block-library/blocks/gallery/style.css 1.59 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 159 B
build/block-library/blocks/group/editor.css 159 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 114 B
build/block-library/blocks/heading/style.css 114 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 332 B
build/block-library/blocks/html/editor.css 333 B
build/block-library/blocks/image/editor-rtl.css 728 B
build/block-library/blocks/image/editor.css 728 B
build/block-library/blocks/image/style-rtl.css 482 B
build/block-library/blocks/image/style.css 487 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 284 B
build/block-library/blocks/latest-comments/style.css 284 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 528 B
build/block-library/blocks/latest-posts/style.css 527 B
build/block-library/blocks/list/style-rtl.css 94 B
build/block-library/blocks/list/style.css 94 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 488 B
build/block-library/blocks/media-text/style.css 485 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 568 B
build/block-library/blocks/navigation-link/editor.css 570 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 300 B
build/block-library/blocks/navigation-submenu/editor.css 299 B
build/block-library/blocks/navigation-submenu/style-rtl.css 195 B
build/block-library/blocks/navigation-submenu/style.css 195 B
build/block-library/blocks/navigation-submenu/view.min.js 343 B
build/block-library/blocks/navigation/editor-rtl.css 1.72 kB
build/block-library/blocks/navigation/editor.css 1.72 kB
build/block-library/blocks/navigation/style-rtl.css 1.48 kB
build/block-library/blocks/navigation/style.css 1.47 kB
build/block-library/blocks/navigation/view.min.js 2.74 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 377 B
build/block-library/blocks/page-list/editor.css 377 B
build/block-library/blocks/page-list/style-rtl.css 198 B
build/block-library/blocks/page-list/style.css 198 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 273 B
build/block-library/blocks/paragraph/style.css 273 B
build/block-library/blocks/post-author/editor-rtl.css 210 B
build/block-library/blocks/post-author/editor.css 210 B
build/block-library/blocks/post-author/style-rtl.css 182 B
build/block-library/blocks/post-author/style.css 181 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-content/editor-rtl.css 138 B
build/block-library/blocks/post-content/editor.css 138 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 398 B
build/block-library/blocks/post-featured-image/editor.css 398 B
build/block-library/blocks/post-featured-image/style-rtl.css 143 B
build/block-library/blocks/post-featured-image/style.css 143 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 378 B
build/block-library/blocks/post-template/style.css 379 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 378 B
build/block-library/blocks/pullquote/style.css 378 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 262 B
build/block-library/blocks/query-pagination/editor.css 255 B
build/block-library/blocks/query-pagination/style-rtl.css 234 B
build/block-library/blocks/query-pagination/style.css 231 B
build/block-library/blocks/query-title/editor-rtl.css 85 B
build/block-library/blocks/query-title/editor.css 85 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 187 B
build/block-library/blocks/quote/style.css 187 B
build/block-library/blocks/quote/theme-rtl.css 220 B
build/block-library/blocks/quote/theme.css 222 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 374 B
build/block-library/blocks/search/style.css 375 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 250 B
build/block-library/blocks/separator/style.css 250 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 474 B
build/block-library/blocks/shortcode/editor.css 474 B
build/block-library/blocks/site-logo/editor-rtl.css 462 B
build/block-library/blocks/site-logo/editor.css 464 B
build/block-library/blocks/site-logo/style-rtl.css 153 B
build/block-library/blocks/site-logo/style.css 153 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 84 B
build/block-library/blocks/site-title/editor.css 84 B
build/block-library/blocks/social-link/editor-rtl.css 165 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/social-links/editor-rtl.css 812 B
build/block-library/blocks/social-links/editor.css 811 B
build/block-library/blocks/social-links/style-rtl.css 1.3 kB
build/block-library/blocks/social-links/style.css 1.3 kB
build/block-library/blocks/spacer/editor-rtl.css 307 B
build/block-library/blocks/spacer/editor.css 307 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 471 B
build/block-library/blocks/table/editor.css 472 B
build/block-library/blocks/table/style-rtl.css 481 B
build/block-library/blocks/table/style.css 481 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 636 B
build/block-library/blocks/template-part/editor.css 635 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 571 B
build/block-library/blocks/video/editor.css 572 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 853 B
build/block-library/common.css 849 B
build/block-library/editor-rtl.css 9.76 kB
build/block-library/editor.css 9.75 kB
build/block-library/reset-rtl.css 527 B
build/block-library/reset.css 527 B
build/block-library/style-rtl.css 10.3 kB
build/block-library/style.css 10.3 kB
build/block-library/theme-rtl.css 665 B
build/block-library/theme.css 669 B
build/block-serialization-default-parser/index.min.js 1.09 kB
build/block-serialization-spec-parser/index.min.js 2.79 kB
build/blocks/index.min.js 47 kB
build/components/index.min.js 209 kB
build/components/style-rtl.css 15.9 kB
build/components/style.css 15.9 kB
build/compose/index.min.js 10.3 kB
build/core-data/index.min.js 12.3 kB
build/customize-widgets/index.min.js 11.1 kB
build/customize-widgets/style-rtl.css 1.5 kB
build/customize-widgets/style.css 1.49 kB
build/data-controls/index.min.js 614 B
build/data/index.min.js 7.1 kB
build/date/index.min.js 31.5 kB
build/deprecated/index.min.js 428 B
build/dom-ready/index.min.js 304 B
build/dom/index.min.js 4.45 kB
build/edit-navigation/index.min.js 15.5 kB
build/edit-navigation/style-rtl.css 3.69 kB
build/edit-navigation/style.css 3.69 kB
build/edit-post/classic-rtl.css 492 B
build/edit-post/classic.css 494 B
build/edit-post/index.min.js 29 kB
build/edit-post/style-rtl.css 7.18 kB
build/edit-post/style.css 7.17 kB
build/edit-site/index.min.js 27.4 kB
build/edit-site/style-rtl.css 5.21 kB
build/edit-site/style.css 5.21 kB
build/edit-widgets/index.min.js 16.1 kB
build/edit-widgets/style-rtl.css 4.09 kB
build/edit-widgets/style.css 4.09 kB
build/editor/index.min.js 37.4 kB
build/editor/style-rtl.css 3.76 kB
build/editor/style.css 3.75 kB
build/element/index.min.js 3.17 kB
build/escape-html/index.min.js 517 B
build/format-library/index.min.js 5.34 kB
build/format-library/style-rtl.css 668 B
build/format-library/style.css 670 B
build/hooks/index.min.js 1.55 kB
build/html-entities/index.min.js 424 B
build/i18n/index.min.js 3.6 kB
build/is-shallow-equal/index.min.js 501 B
build/keyboard-shortcuts/index.min.js 1.72 kB
build/keycodes/index.min.js 1.3 kB
build/list-reusable-blocks/index.min.js 1.85 kB
build/list-reusable-blocks/style-rtl.css 838 B
build/list-reusable-blocks/style.css 838 B
build/media-utils/index.min.js 2.88 kB
build/notices/index.min.js 845 B
build/nux/index.min.js 2.03 kB
build/nux/style-rtl.css 747 B
build/nux/style.css 743 B
build/plugins/index.min.js 1.83 kB
build/primitives/index.min.js 921 B
build/priority-queue/index.min.js 582 B
build/react-i18n/index.min.js 671 B
build/redux-routine/index.min.js 2.63 kB
build/reusable-blocks/index.min.js 2.28 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.6 kB
build/server-side-render/index.min.js 1.5 kB
build/shortcode/index.min.js 1.48 kB
build/token-list/index.min.js 562 B
build/url/index.min.js 1.74 kB
build/viewport/index.min.js 1.02 kB
build/warning/index.min.js 248 B
build/widgets/index.min.js 7.11 kB
build/widgets/style-rtl.css 1.16 kB
build/widgets/style.css 1.16 kB
build/wordcount/index.min.js 1.04 kB

compressed-size-action

@jasmussen
Copy link
Contributor

This is cool, two big ingredients in this one, both new patterns for the navigation block, and the ability to preset labels without URLs in patterns:

patterns and placeholders

The patterns are useful if very basic, I do wonder what level we need these to reach before shipping. On the other hand, it's very easy to replace an existing pattern with an upgraded one, without having to worry about deprecations. Could we ship these in the plugin only, somehow, until we feel satisfied with the designs? That way I could potentially upgrade them without blocking your work here.

The ability to set a label, but not a URL, I'm a fan of. The benefit to this approach is that at least there's a wavy underline indicating that this item links nowhere, click it to address that. Already now you can insert patterns with buttons that link nowhere, with no indication thereof:

Screenshot 2021-09-23 at 09 40 10

At least the wavy underline is some indication that this item is missing a link.

So in that vein, I think that a) it's important we can create visually impressive patterns, even with preset labels, and b) the wavy underline can be a start, and then we can see how to upgrade/adjust if we find it insufficient. Some ideas I've seen to support this is to provide chip or dot indicators in the list view to indicate, "this item is missing a link", and to surface blocks with missing links as part of the pre-publish flow. In such an environment, the wavy underline would be an in-canvas extra affordance, not the only affordance.

Are navigation patterns (outside of site header) patterns useful? Is there a better spot for these.

Now that we can include site logo and title in the navigation, in addition to social links and search, I think it's a fine thing to do. Especially if we can keep these plugin only as we refine them. I would very much love to pair with you on bringing these home, and this list of patterns from @mtias might be useful inspiration.

CC: @kjellr if you have any thoughts, or designs we could leverage, in lieu of #31231.

Also wanted to point to #30170 (comment) as mockups for enhancing the building experience of these.

@priethor
Copy link
Contributor

Are navigation patterns (outside of site header) patterns useful? Is there a better spot for these.

I think a category makes sense, and when #28739 is implemented, we could show or hide the Navigation category patterns depending on the context.

I agree with @jasmussen; with the recent improvements he mentioned, the block gap support, and the design tools enhancements to Site Title, Site Logo, and Social Links blocks, some of the linked patterns can already be implemented.

@jasmussen
Copy link
Contributor

One pattern that is within reach is 4 menu items, space between, and a rounded style Site Logo in the middle. Something a la this:
Frame 1

But for that to be a useful pattern, it would have to be the actual Site Logo block, which also means the pattern would be less compelling if a site logo hasn't been set. Can we pre-populate the Site Logo block with an image? Or can we show the pattern only if a Site Logo has been set?

@priethor
Copy link
Contributor

Can we pre-populate the Site Logo block with an image? Or can we show the pattern only if a Site Logo has been set?

Although hiding the pattern could be easier, displaying the pattern even if the user didn't set a Site Logo is a good way to showcase such a block/feature. I believe patterns can act as a demonstration and help users discover blocks such as the Site Logo block, and this approach would open more design possibilities than hiding the patterns altogether.

@gwwar
Copy link
Contributor Author

gwwar commented Sep 23, 2021

I would very much love to pair with you on bringing these home

Definitely happy to pair with you on these @jasmussen ✨ I wasn't sure how experimental we could get with patterns outside of themes so I started with just some basic examples. I think even just trying to build these should be a good exercise in seeing if we're still missing functionality / any misc bugs that arise.

Can we pre-populate the Site Logo block with an image? Or can we show the pattern only if a Site Logo has been set?

I can look into options today. We will need to gate display of the pattern based on theme since we only register the site blocks when we detect a block based theme. (Maybe we can pass an image to the preview code only).

Could we ship these in the plugin only, somehow, until we feel satisfied with the designs?

Did you mean one of the theme plugins or Gutenberg? One thing I can do is pull out the label change and land that first to unblock any pattern work.

@jasmussen
Copy link
Contributor

Gutenberg plugin for now. I'm waffling a bit though, these patterns are more functional shortcuts that artistic expressions, at least for now, and maybe that's ok? It's something to think about 🤔

@gwwar
Copy link
Contributor Author

gwwar commented Sep 23, 2021

I think we can still make these look good, it's definitely more of a challenge when they may be dropped in any theme

@jasmussen
Copy link
Contributor

To clarify a bit more: my instinct is that it would be a more inspiring experience if when you browse the pattern interface, that you see opinionated patterns that look exactly like those concepts Matias shared, i.e. with color and logos and everything. Almost as if you design a website, then cut it into sections. This is where the Site Logo becomes a challenge because it's just a clunky placeholder when inserted. If we could prefill it with a logo of sorts, I wonder if that would make for a better experience. It would at the very least provide a more exciting preview.

@gwwar gwwar changed the title Navigation: Allow a label to be used for placeholder text. Navigation: add new patterns Sep 23, 2021
@gwwar
Copy link
Contributor Author

gwwar commented Sep 23, 2021

I pulled out the label change in navigation-link to #35094

@kjellr
Copy link
Contributor

kjellr commented Sep 23, 2021

The patterns here seem pretty relevant to this old PR. It even includes the one @jasmussen mentioned above.

I don't have bandwidth to refresh this week, but I think the blockers we were seeing before should be mostly gone now that flex/gap functionality is available.

@jasmussen
Copy link
Contributor

That's awesome, Kjell. In your version, is this pattern one or two navigation blocks, and is the image a site logo or just an image block? One thing recent changes enable is to use the site logo directly between two menu items. The site-logo is still a headscratcher, though.

@gwwar
Copy link
Contributor Author

gwwar commented Sep 23, 2021

@kjellr @jasmussen should we close out this one and prefer #31610?

I can help rebase that branch

@kjellr
Copy link
Contributor

kjellr commented Sep 23, 2021

That's awesome, Kjell. In your version, is this pattern one or two navigation blocks, and is the image a site logo or just an image block? One thing recent changes enable is to use the site logo directly between two menu items. The site-logo is still a headscratcher, though.

It was two navigation items because at the time it wasn't possible to put the site logo a nav block. But using one navigation block is way better. 😄

@kjellr @jasmussen should we close out this one and prefer #31610?

I'm not sure — that one was specifically for the template part block, though there's a lot of overlap for navigation.

@jasmussen
Copy link
Contributor

I added an initial mockup to how we can improve the site logo placeholder in #35096 (comment). Of note, the site logo placeholder should take the style from the block, as well as dimensions, even in the initial state. The rounded aspect is already possible, even if it isn't reflected in the placeholder:
Screenshot 2021-09-24 at 09 17 31

But as far as I can tell, the dimensions are not possible to set in that state yet.

@carolinan
Copy link
Contributor

Are there any plans to refresh this?

@kjellr
Copy link
Contributor

kjellr commented Apr 6, 2022

No, there aren't. I'll going to close it. Header patterns should go in the pattern directory moving forward. Just waiting on a resolution here: WordPress/pattern-directory#395

@kjellr kjellr closed this Apr 6, 2022
@kjellr kjellr deleted the try/navigation-patterns branch April 6, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants