Build plugin zip: Verify npm cache before a clean install #34973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
The `Build Release Artifact` step of the `Build Plugin Zip` GH action sometimes fails because of `npm` cache issues. Namely, it fails with a `npm ERR cb() never called` error message. This attempt to verify the cache before the `ci` to give `npm` a chance to repair it, if needed.
fullofcaffeine
force-pushed
the
fix/gh-action-npm-cache-issue
branch
from
b9b9529
to
59e0a60
Compare
oandregal
reviewed
Sep 20, 2021
| @@ -99,6 +99,7 @@ done | |||
|
|
|||
| # Run the build. | |||
| status "Installing dependencies... 📦" | |||
| npm cache verify | |||
There was a problem hiding this comment.
We've been experiencing some issues like the one at https://github.com/WordPress/gutenberg/runs/3654626964?check_suite_focus=true for other npm install and npm ci in GitHub Actions. Tracked at #33424 They seem related to some packages that we point to the GitHub SHA instead of the npm package. When there're network issues, things fall apart.
That was just for context. We can still try doing this to see if it improves the situation for the plugin job.
There was a problem hiding this comment.
We've tried running the action a number of times and it fails https://github.com/WordPress/gutenberg/actions/runs/1254846943 and https://github.com/WordPress/gutenberg/actions/runs/1254532616
oandregal
approved these changes
Sep 20, 2021
fullofcaffeine
added a commit
that referenced
this pull request
Sep 20, 2021
The `Build Release Artifact` step of the `Build Plugin Zip` GH action sometimes fails because of `npm` cache issues. Namely, it fails with a `npm ERR cb() never called` error message. This attempt to verify the cache before the `ci` to give `npm` a chance to repair it, if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Build Release Artifactstep of theBuild Plugin ZipGH action sometimes fails because ofnpmcache issues. Namely, it could fail with anpm ERR cb() never callederror message. This attempt to verify the cache before thecito givenpma chance to repair it, if needed.