Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Supports: Switch dimensions inspector controls slot to bubble virtually #34725

Merged
merged 16 commits into from Oct 8, 2021
Merged

Block Supports: Switch dimensions inspector controls slot to bubble virtually #34725

merged 16 commits into from Oct 8, 2021

Commits on Sep 24, 2021

  1. Switch dimensions inspector controls slot to bubble virtually

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    220911c View commit details
    Browse the repository at this point in the history

  2. Move creation of ToolsPanel to within fills 

    Creating the ToolsPanel for block supports around the slot resulted in the slot adding an extra div within the ToolsPanel breaking its layout. This div is needed for the slot's ref to be applied allowing virtual bubbling.  This change effectively moves the ToolsPanel inside that. It also avoids needing to retrieve ToolsPanelContext and recreating the context provider.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    326d3d2 View commit details
    Browse the repository at this point in the history

  3. Revert "Move creation of ToolsPanel to within fills" 

    This reverts commit 94f444c.
    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    8d238f7 View commit details
    Browse the repository at this point in the history

  4. Remove unused header prop

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    72d556e View commit details
    Browse the repository at this point in the history

  5. Fix layout when slot injects wrapping div inside tools panel

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    9b09362 View commit details
    Browse the repository at this point in the history

  6. Add optional placeholder rendering to maintain order of fills

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    8507363 View commit details
    Browse the repository at this point in the history

  7. Use props to setup handling of wrapper div and empty styles

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    e5809a8 View commit details
    Browse the repository at this point in the history

  8. Replace is-empty tests with ones specific to item order

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    5d4677c View commit details
    Browse the repository at this point in the history

  9. Add hasInnerWrapper to ToolsPanelProps type

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    0749b9b View commit details
    Browse the repository at this point in the history

  10. Add new props to ToolsPanel README

    @aaronrobertshaw
    aaronrobertshaw committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    84ba3b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Fix description of hasInnerWrapper prop

    @aaronrobertshaw
    aaronrobertshaw committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    6d54a19 View commit details
    Browse the repository at this point in the history

  2. Improve shouldRenderPlaceholderItems description

    @aaronrobertshaw
    aaronrobertshaw committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b1b93b5 View commit details
    Browse the repository at this point in the history

  3. Fix comment regarding tracking optional menu items

    @aaronrobertshaw
    aaronrobertshaw committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    a148041 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Move classname computations into useMemo hooks

    @aaronrobertshaw
    aaronrobertshaw committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    540bcb3 View commit details
    Browse the repository at this point in the history

  2. Refactor shared grid layout styles

    @aaronrobertshaw
    aaronrobertshaw committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    ce2ef0a View commit details
    Browse the repository at this point in the history

  3. Tweak cleanup for controlProps in tests

    @aaronrobertshaw
    aaronrobertshaw committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    022c19f View commit details
    Browse the repository at this point in the history