Gallery Block: Get media data in a single request #34389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Gallery
|
@glendaviesnz, Unless I'm misreading logic in |
|
Size Change: -607 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Thanks for looking into this @Mamaduka. I got really excited about 6 months ago when I discovered the
I did play around with trying to page the results to groups of 100 for galleries > 100, but that caused a lot of weird issues that I couldn't resolve at the time. But, you may have some thoughts on how to effectively page these calls. |
|
Thanks for the feedback, @glendaviesnz. Interestingly, most of the entities support I'm not sure if this was intentional or overlooked, but I will try to find out. |
|
@glendaviesnz created the PR to fix the issue with |
7 tasks
Mamaduka
force-pushed
the
try/gallery-reduce-requests
branch
from
9e51ff6
to
7755d06
Compare
|
Hi, @glendaviesnz I just merged #34417 today. Should I move forward with this PR? |
Yes, definitely worth switching this to the |
|
Thanks for the enhancement! I'll test the mobile side of this. It looks like this will be a great improvement there as well 👍 |
glendaviesnz
approved these changes
Oct 4, 2021
|
Thanks for testing and review, @glendaviesnz. @mkevins, let me know when you get the chance to test the mobile side of this enhancement. |
Hi @Mamaduka 👋 😄 I actually tried to get to this earlier this week, but ran into other issues (unrelated with this PR) which prevented me from testing this. We are currently debugging an issue (potentially a cache issue) with the flag which enables the refactored gallery. My apologies for the unexpected delay. |
|
@mkevins, no worries 👍 |
|
I have to admit that using |
|
@aristath, what do you think about using |
|
Ah I missed the fact that there's an |
aristath
approved these changes
Oct 8, 2021
|
Hi @Mamaduka 👋 😄 I was able to test this, and inspecting the requests in the profiler confirms that this reduces the number of requests for mobile as well! Nice work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With recent Gallery block refactoring now, it's possible to request media data in a single call instead of N numbers of requests.
The small downside of this change is that it will fire a new request when a gallery item (Image block) is selected. But I think this still improves the initial load of image data.
Fixes #10994.
How has this been tested?
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).