Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders: Switch to ToolsPanel for displaying UI #33743

Merged
merged 14 commits into from Nov 29, 2021

Commits on Nov 29, 2021

  1. Move creation of ToolsPanel to within fills

    Creating the ToolsPanel for block supports around the slot resulted in the slot adding an extra div within the ToolsPanel breaking its layout. This div is needed for the slot's ref to be applied allowing virtual bubbling.  This change effectively moves the ToolsPanel inside that. It also avoids needing to retrieve ToolsPanelContext and recreating the context provider.
    aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    9015c87 View commit details
    Browse the repository at this point in the history
  2. Revert "Move creation of ToolsPanel to within fills"

    This reverts commit 94f444c.
    aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    ed7538b View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    c4d0a44 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    1d90049 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    aa817c9 View commit details
    Browse the repository at this point in the history
  6. Update border support to use ToolsPanel

    Update border support to display via progressive disclosure panel
    
    Updating border support UI styling for grid layout
    
    Update border global styles panel
    
    Fix border global style hasValue checks
    aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    d6c2faa View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    821d08a View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    9414eeb View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    8414e9d View commit details
    Browse the repository at this point in the history
  10. Update border support use of ToolsPanel

    These changes include adding a new border group to the inspector controls slots and updating the border tools panel to match the latest changes to that component.
    aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    315720b View commit details
    Browse the repository at this point in the history
  11. Linting

    stacimc authored and aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    56a6ac3 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    8c195d3 View commit details
    Browse the repository at this point in the history
  13. Border panel: Update panel layout (#35938)

    * Restore single-column styling for appropriate controls
    
    * Remove clear button from Color picker in ToolsPanel
    stacimc authored and aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    02335dc View commit details
    Browse the repository at this point in the history
  14. Try adding some default fallbacks

    When a user first sets a border width or color their may not be a border style set. These changes aim to provide a fallback for that (in the frontend/block editor) or apply a border style by default in the site editor for Global Styles.
    aaronrobertshaw committed Nov 29, 2021
    Copy the full SHA
    3a8e748 View commit details
    Browse the repository at this point in the history