Improve Feature mapping in automatically generated changelog
#33625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -113 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
priethor
reviewed
Jul 22, 2021
There was a problem hiding this comment.
Love to see more improvements in this direction!
Not directly tied to this PR, but one more thing we need to reevaluate is the precedence of feature types. For example, because the sortType function gives more precedence to labels with a lower index in LABEL_TYPE_MAPPING, a PR with both [Type] Bug and Documentation will get grouped with bugs. In practice, this has been the other way around in recent releases.
getdave
commented
Jul 23, 2021
gziolo
reviewed
Jul 23, 2021
gziolo
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #33229 we introduced a mechanism which attempts to automatically assign PRs to a given "Feature" within each section.
Previously this task was completed manually so this was a good step forward.
Note we do not need to manually map all features. Anything marked with a Block specific label will be mapped to
Block Library. Similarly anything labelled with[Feature] Xlabel will be automatically mapped to a feature namedX(or whatever the name of the feature in the label is).Despite this however, the mapping is currently rather bare bones and needs augmenting. Some
[Feature]labels are best mapped to a specific feature. Manual intervention is required.To this end this PR adds additional mapping of Github labels to the feature we feel best matches.
Please feel free to submit additional mappings either by:
The mapping is easily improved by cross referencing the human-made mapping that @gwwar undertook for
11.1.0. Let's look at how she mapped the PRs to features and cross reference the labels. From that we shoudl be able to tell which labels are best mapped to which features.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).