Specify use of 5.7 branch for wp/5.7. #32685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP Unit test are passing as expected. JavaScript tests are failing but the cause appears to be |
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Looking at the commit history I've decided you two own tests, lucky you :) Using the correct version of WP on this branch is resulting in fewer failures but I'm still getting a few:
Is there anything else I should take a look at while attempting to use the correct WP on each WP/* branch? |
gziolo
added
the
[Type] Automated Testing
|
E2E test failures are concerning, but it's also worth noting that it'd be a very unusual configuration to use the Gutenberg plugin to override the same set of features that are already in WordPress core. In practice, @youknowriad, @noisysocks and @ockham, can you help with reasoning about the best approach for enabling automated testing for WP major release branches? One more thing. In practice, we can skip all React Native related GitHub workflows for this branch because they don't need to work since this branch will never be used to build a mobile app. |
|
Ideally, in these branches we'd run unit tests and e2e tests essentially and ideally the docker image used should be For the caniuse, we should probably add a way to ignore these warnings in the tests because we don't want to update the browserlist in these old branches to avoid having different JS output. |
For the
Agreed. Would that require writing a custom exception handler for the older branches or is there a configuration option to ignore specific errors? |
I tend to agree with this stance. |
peterwilsoncc
added a commit
that referenced
this pull request
Jul 19, 2021
|
@peterwilsoncc Hi Peter! Are you still working on this PR? What still needs to be done to close/merge this? |
peterwilsoncc
force-pushed
the
wp57-specify-branch
branch
from
25ff76f
to
29b1d11
Compare
This reverts commit 29b1d11.
|
It looks like core was pinned in 09683c1 so I think the main purpose of this PR is obsolete. I'm not sure why the tests are failing but the same thing happens on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifies the WP 5.7 branch be used as the WordPress install for the
wp/5.7Gutenberg branch.How has this been tested?
Untested, seeing if the test suite runs successfully to find out if it works.
Screenshots
Types of changes
Build tools: Changes for accuracy in testing WP version.
Checklist:
*.native.jsfiles for terms that need renaming or removal).