Font family: switch from CSS Custom Property to classes #31910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
the
Global Styles
|
Size Change: +663 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Quick check-in with @nosolosw (before I start working on migrations): Are we okay with introducing a new top-level It seemed to me that Furthermore, is it our responsibility to translate the class to a style on the frontend, or is it the theme's to style it accordingly? (I guess it's ours?) Curious to hear your thoughts. |
ockham
commented
May 18, 2021
ockham
commented
May 18, 2021
ockham
force-pushed
the
update/font-family-block-supports-use-classes
branch
from
e3558f2
to
e01c679
Compare
oandregal
force-pushed
the
update/font-family-block-supports-use-classes
branch
from
e01c679
to
a72d930
Compare
oandregal
reviewed
Jul 2, 2021
oandregal
reviewed
Jul 2, 2021
oandregal
changed the title
|
Worked a bit on this today and this is working. Tasks left are: block deprecations + update tests. |
oandregal
force-pushed
the
update/font-family-block-supports-use-classes
branch
from
eb1881f
to
bdddb96
Compare
|
I've picked up this today and updated the tests. The remaining step is to add block deprecations. |
oandregal
force-pushed
the
update/font-family-block-supports-use-classes
branch
3 times, most recently
from
1cdbc43
to
846e8de
Compare
|
I've pushed the last bits necessary to land this, and it's ready. |
oandregal
requested review from
ajitbohra,
ellatrix,
spacedmonkey and
TimothyBJacobs
as code owners
oandregal
force-pushed
the
update/font-family-block-supports-use-classes
branch
from
6e8b1cb
to
19dbeee
Compare
That's correct! It was also what I meant but my English skills are failing me, apparently 👼
Great catch. I was misguided because I checked the lines of those migrations that were actually modified later (to add newer migrations). |
ockham
commented
Oct 20, 2021
There was a problem hiding this comment.
I went through all newly modified files again (and added two attributes to two deprecations that have been added very recently, i.e. in the past few hours), and verified that the composed deprecations work, as described here and here.
I didn't do another round of manually testing all block deprecations since I think those are covered fine by the fixtures.
Anyway, LGTML! Let's land this 👍 ✨ 🚢 💥
This was referenced Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31489
This PR switches the font-family property to use class names instead of CSS Custom Properties, following what the other properties do.
How has this been tested?
Block markup changes
Before
After
Screencasts
Before
After
Tasks
style.typography.fontFamilyinto a top-levelfontFamilyattribute.