Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List: Add ability to only show child pages #31471

Closed
wants to merge 6 commits into from
Closed

Page List: Add ability to only show child pages #31471

wants to merge 6 commits into from

Commits on Oct 30, 2021

  1. Update Page List with toggle to show child pages 

    - Adds a showOnlyChildPages attribute to Edit
- Update render to use attribute and only pull in children
- Do not show on post pages which will not have a parent
- Allow showing on wp_template pages

Fixes #31063
    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    c60c176 View commit details
    Browse the repository at this point in the history

  2. Update verbiage explaining control

    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    56a3fa8 View commit details
    Browse the repository at this point in the history

  3. Simplify if-else for setting top/child pages, makes linter happier

    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    984be2c View commit details
    Browse the repository at this point in the history

  4. Reverse logic on when to display toggle 

    The toggle was set to show explictly on certain posts types but it is
easier to hide on post types so it will show on others such was
templates, template parts, or menus.
    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    4622e80 View commit details
    Browse the repository at this point in the history

  5. Update logic for checking top-level and child pages 

    Moves check for top level and child checks to its own function so it
came be a little more clear what it is doing and why.

When the only_child_pages flag is set, we need to treat direct
child pages to the parent as top level so they show. And treat grand
children pages as child pages so they nest.
    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    ac19e71 View commit details
    Browse the repository at this point in the history

  6. Fix rebasing issues

    @mkaz
    mkaz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    83ef45c View commit details
    Browse the repository at this point in the history