Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover: Add custom border support to the cover block #31370

Closed
wants to merge 6 commits into from
Closed

Cover: Add custom border support to the cover block #31370

wants to merge 6 commits into from

Commits on May 16, 2022

  1. Add border support to the cover block

    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e028ca3 View commit details
    Browse the repository at this point in the history

  2. Add baseline border styles for cover block 

    These new styles have zero specificity and are easily overridden by theme or global styles. They however ensure there is some value set such that a user is more likely to be given immediate visual feedback when editing individual border properties.
    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a9c13d6 View commit details
    Browse the repository at this point in the history

  3. Try moving application of border in the editor to improve UX

    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9d79d94 View commit details
    Browse the repository at this point in the history

  4. Refine application of borders and display in editor 

    This still isn't perfect. The cover content/background appears to be "under" dashed/dotted borders in the editor but are instead contained within them on the frontend.
    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ac7cdcd View commit details
    Browse the repository at this point in the history

  5. Try new approach to handling cover borders in editor

    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    7de91ca View commit details
    Browse the repository at this point in the history

  6. Re-apply edit component changes after controls refactoring

    @aaronrobertshaw
    aaronrobertshaw committed May 16, 2022
    Configuration menu
    Copy the full SHA
    c9b9909 View commit details
    Browse the repository at this point in the history